Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 243253002: "Reverting 35157" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index d98933180c60e0df173b54f0fbad5d2d3f5ec867..41a74ab7427abb1a76b1a26b5e6942b8c653b561 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -83,7 +83,7 @@ abstract class Browser {
const ['safari', 'ff', 'firefox', 'chrome', 'ie9', 'ie10',
'ie11', 'dartium'];
- static const List<String> BROWSERS_WITH_WINDOW_SUPPORT = const [];
+ static const List<String> BROWSERS_WITH_WINDOW_SUPPORT = const ['ie11'];
// TODO(kustermann): add standard support for chrome on android
static bool supportedBrowser(String name) {
@@ -1374,12 +1374,6 @@ class BrowserTestingServer {
number_div.innerHTML = number_of_tests;
executing_div.innerHTML = url;
if (use_iframe) {
- var embedded_iframe = document.getElementById('embedded_iframe');
- embedded_iframe.parentNode.removeChild(embedded_iframe);
-
- embedded_iframe = document.createElement('iframe');
- embedded_iframe.id = 'embedded_iframe';
- document.body.appendChild(embedded_iframe);
embedded_iframe.src = url;
} else {
if (typeof testing_window != 'undefined') {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698