third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp - Issue 2432493002: Handle RTCCertificate::fromPEM returning nullptr, with a unit test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp

Issue 2432493002: Handle RTCCertificate::fromPEM returning nullptr, with a unit test. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/test_blink_web_unit_test_support.cc ('K') | « content/test/test_blink_web_unit_test_support.cc ('k') | third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueDeserializerForModules.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp

index bf71ed1d0f5ce7b7e67c7fbcfcd0eda48d8d2a46..334f4a9434b239eb0344d009c664f2985c4a795c 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp

@@ -412,6 +412,8 @@ bool SerializedScriptValueReaderForModules::readRTCCertificate(

std::unique_ptr<WebRTCCertificate> certificate(

certificateGenerator->fromPEM(pemPrivateKey, pemCertificate));

+ if (!certificate)

+ return false;

RTCCertificate* jsCertificate = new RTCCertificate(std::move(certificate));

*value =