Handle RTCCertificate::fromPEM returning nullptr, with a unit test.

content/test/test_blink_web_unit_test_support.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/test_blink_web_unit_test_support.h"
 
 #include "base/feature_list.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
@@ skipping 312 matching lines @@
       uint64_t expires_ms,
       std::unique_ptr<blink::WebRTCCertificateCallback> callback) override {
     NOTIMPLEMENTED();
   }
   bool isSupportedKeyParams(const blink::WebRTCKeyParams& key_params) override {
     return false;
   }
   std::unique_ptr<blink::WebRTCCertificate> fromPEM(
       blink::WebString pem_private_key,
       blink::WebString pem_certificate) override {
-    return base::MakeUnique<RTCCertificate>(
+    rtc::scoped_refptr<rtc::RTCCertificate> certificate =
         rtc::RTCCertificate::FromPEM(rtc::RTCCertificatePEM(
-            pem_private_key.utf8(), pem_certificate.utf8())));
+            pem_private_key.utf8(), pem_certificate.utf8()));
+    if (!certificate)
+      return nullptr;
+    return base::MakeUnique<RTCCertificate>(certificate);

[sky, 2016/10/21 23:13:11]

Is RTCCertificate and rtc::RTCCertificate different?

[jbroman, 2016/10/22 15:33:26]

Yes, the former is content::RTCCertificate (in content/renderer/media/, which
derives from blink::WebRTCCertificate) and the latter is rtc::RTCCertificate (in
third_party/webrtc/), which is what's held internally in
content::RTCCertificate.

   }
 };
 
 }  // namespace
 #endif  // defined(ENABLE_WEBRTC)
 
 blink::WebRTCCertificateGenerator*
 TestBlinkWebUnitTestSupport::createRTCCertificateGenerator() {
 #if defined(ENABLE_WEBRTC)
   return new TestWebRTCCertificateGenerator();
 #else
   return nullptr;
 #endif
 }
 
 }  // namespace content