Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2432443002: Fix Include Syntax (Closed)

Created:
4 years, 2 months ago by jdoerrie
Modified:
4 years, 2 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Include Syntax Using the wrong include syntax for non-system headers can lead to cases where the compiler is unable to find the corresponding file. This CL aims to fix an improper include syntax for non-sytem headers. BUG=656983 Committed: https://crrev.com/8c407cea3c723056660b15f09649d2c0fc7c5924 Cr-Commit-Position: refs/heads/master@{#425951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jdoerrie
4 years, 2 months ago (2016-10-18 13:36:57 UTC) #2
vabr (Chromium)
LGTM, thanks a lot! Vaclav
4 years, 2 months ago (2016-10-18 13:37:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432443002/1
4 years, 2 months ago (2016-10-18 13:38:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 14:15:43 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 14:19:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c407cea3c723056660b15f09649d2c0fc7c5924
Cr-Commit-Position: refs/heads/master@{#425951}

Powered by Google App Engine
This is Rietveld 408576698