Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(230)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: xfa/fwl/core/ifwl_timer.cpp
Issue
2432423002
:
Merge the CFWL_*Imp classes into the IFWL_* classes. (Closed)
Patch Set: Review feedback
Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
BUILD.gn
core/fpdfapi/page/cpdf_textstate.cpp
xfa/fde/cfde_txtedtdorecord_deleterange.cpp
xfa/fde/cfde_txtedtdorecord_insert.cpp
xfa/fde/cfde_txtedtengine.cpp
xfa/fde/ifde_txtedtengine.h
xfa/fwl/basewidget/cfx_barcode.h
xfa/fwl/basewidget/cfx_barcode.cpp
xfa/fwl/basewidget/fwl_barcodeimp.h
xfa/fwl/basewidget/fwl_barcodeimp.cpp
xfa/fwl/basewidget/fwl_caretimp.h
xfa/fwl/basewidget/fwl_caretimp.cpp
xfa/fwl/basewidget/fwl_checkboximp.h
xfa/fwl/basewidget/fwl_checkboximp.cpp
xfa/fwl/basewidget/fwl_comboboximp.h
xfa/fwl/basewidget/fwl_comboboximp.cpp
xfa/fwl/basewidget/fwl_datetimepickerimp.h
xfa/fwl/basewidget/fwl_datetimepickerimp.cpp
xfa/fwl/basewidget/fwl_editimp.h
xfa/fwl/basewidget/fwl_editimp.cpp
xfa/fwl/basewidget/fwl_formproxyimp.h
xfa/fwl/basewidget/fwl_formproxyimp.cpp
xfa/fwl/basewidget/fwl_listboximp.h
xfa/fwl/basewidget/fwl_listboximp.cpp
xfa/fwl/basewidget/fwl_monthcalendarimp.h
xfa/fwl/basewidget/fwl_monthcalendarimp.cpp
xfa/fwl/basewidget/fwl_pictureboximp.h
xfa/fwl/basewidget/fwl_pictureboximp.cpp
xfa/fwl/basewidget/fwl_pushbuttonimp.h
xfa/fwl/basewidget/fwl_pushbuttonimp.cpp
xfa/fwl/basewidget/fwl_scrollbarimp.h
xfa/fwl/basewidget/fwl_scrollbarimp.cpp
xfa/fwl/basewidget/fwl_spinbuttonimp.h
xfa/fwl/basewidget/fwl_spinbuttonimp.cpp
xfa/fwl/basewidget/fwl_tooltipctrlimp.h
xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp
xfa/fwl/basewidget/ifwl_barcode.h
xfa/fwl/basewidget/ifwl_caret.h
xfa/fwl/basewidget/ifwl_checkbox.h
xfa/fwl/basewidget/ifwl_combobox.h
xfa/fwl/basewidget/ifwl_datetimepicker.h
xfa/fwl/basewidget/ifwl_edit.h
xfa/fwl/basewidget/ifwl_listbox.h
xfa/fwl/basewidget/ifwl_monthcalendar.h
xfa/fwl/basewidget/ifwl_picturebox.h
xfa/fwl/basewidget/ifwl_pushbutton.h
xfa/fwl/basewidget/ifwl_scrollbar.h
xfa/fwl/basewidget/ifwl_spinbutton.h
xfa/fwl/basewidget/ifwl_tooltip.h
xfa/fwl/core/cfwl_message.h
xfa/fwl/core/cfwl_widgetmgr.cpp
xfa/fwl/core/cfx_barcode.h
xfa/fwl/core/cfx_barcode.cpp
xfa/fwl/core/fwl_formimp.h
xfa/fwl/core/fwl_formimp.cpp
xfa/fwl/core/fwl_noteimp.h
xfa/fwl/core/fwl_noteimp.cpp
xfa/fwl/core/fwl_timerimp.cpp
xfa/fwl/core/fwl_widgetimp.h
xfa/fwl/core/fwl_widgetimp.cpp
xfa/fwl/core/ifwl_barcode.h
xfa/fwl/core/ifwl_barcode.cpp
xfa/fwl/core/ifwl_caret.h
xfa/fwl/core/ifwl_caret.cpp
xfa/fwl/core/ifwl_checkbox.h
xfa/fwl/core/ifwl_checkbox.cpp
xfa/fwl/core/ifwl_combobox.h
xfa/fwl/core/ifwl_combobox.cpp
xfa/fwl/core/ifwl_comboedit.h
xfa/fwl/core/ifwl_comboedit.cpp
xfa/fwl/core/ifwl_combolist.h
xfa/fwl/core/ifwl_combolist.cpp
xfa/fwl/core/ifwl_datetimecalendar.h
xfa/fwl/core/ifwl_datetimecalendar.cpp
xfa/fwl/core/ifwl_datetimeedit.h
xfa/fwl/core/ifwl_datetimeedit.cpp
xfa/fwl/core/ifwl_datetimepicker.h
xfa/fwl/core/ifwl_datetimepicker.cpp
xfa/fwl/core/ifwl_edit.h
xfa/fwl/core/ifwl_edit.cpp
xfa/fwl/core/ifwl_form.h
xfa/fwl/core/ifwl_form.cpp
xfa/fwl/core/ifwl_formproxy.h
xfa/fwl/core/ifwl_formproxy.cpp
xfa/fwl/core/ifwl_listbox.h
xfa/fwl/core/ifwl_listbox.cpp
xfa/fwl/core/ifwl_monthcalendar.h
xfa/fwl/core/ifwl_monthcalendar.cpp
xfa/fwl/core/ifwl_picturebox.h
xfa/fwl/core/ifwl_picturebox.cpp
xfa/fwl/core/ifwl_pushbutton.h
xfa/fwl/core/ifwl_pushbutton.cpp
xfa/fwl/core/ifwl_scrollbar.h
xfa/fwl/core/ifwl_scrollbar.cpp
xfa/fwl/core/ifwl_spinbutton.h
xfa/fwl/core/ifwl_spinbutton.cpp
xfa/fwl/core/ifwl_timer.cpp
xfa/fwl/core/ifwl_tooltip.h
xfa/fwl/core/ifwl_tooltip.cpp
xfa/fwl/core/ifwl_widget.h
xfa/fwl/core/ifwl_widget.cpp
xfa/fwl/lightwidget/cfwl_barcode.h
xfa/fwl/lightwidget/cfwl_checkbox.h
xfa/fwl/lightwidget/cfwl_combobox.h
xfa/fwl/lightwidget/cfwl_combobox.cpp
xfa/fwl/lightwidget/cfwl_datetimepicker.h
xfa/fwl/lightwidget/cfwl_datetimepicker.cpp
xfa/fwl/lightwidget/cfwl_edit.h
xfa/fwl/lightwidget/cfwl_edit.cpp
xfa/fwl/lightwidget/cfwl_listbox.h
xfa/fwl/lightwidget/cfwl_listbox.cpp
xfa/fwl/lightwidget/cfwl_picturebox.h
xfa/fwl/lightwidget/cfwl_pushbutton.h
xfa/fwl/lightwidget/cfwl_widget.cpp
xfa/fwl/theme/cfwl_barcodetp.cpp
xfa/fwl/theme/cfwl_carettp.cpp
xfa/fwl/theme/cfwl_checkboxtp.cpp
xfa/fwl/theme/cfwl_comboboxtp.cpp
xfa/fwl/theme/cfwl_datetimepickertp.cpp
xfa/fwl/theme/cfwl_edittp.cpp
xfa/fwl/theme/cfwl_listboxtp.cpp
xfa/fwl/theme/cfwl_monthcalendartp.cpp
xfa/fwl/theme/cfwl_pictureboxtp.cpp
xfa/fwl/theme/cfwl_pushbuttontp.cpp
xfa/fwl/theme/cfwl_scrollbartp.cpp
xfa/fxfa/app/xfa_ffchoicelist.cpp
xfa/fxfa/app/xfa_fffield.cpp
xfa/fxfa/app/xfa_fftextedit.cpp
xfa/fxfa/app/xfa_fwltheme.cpp
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« xfa/fwl/core/ifwl_spinbutton.cpp
('k') |
xfa/fwl/core/ifwl_tooltip.h »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: xfa/fwl/core/ifwl_timer.cpp
diff --git a/xfa/fwl/core/fwl_timerimp.cpp b/xfa/fwl/core/ifwl_timer.cpp
similarity index 100%
rename from xfa/fwl/core/fwl_timerimp.cpp
rename to xfa/fwl/core/ifwl_timer.cpp
« no previous file with comments
|
« xfa/fwl/core/ifwl_spinbutton.cpp
('k') |
xfa/fwl/core/ifwl_tooltip.h »
('j') |
no next file with comments »
Issue 2432423002: Merge the CFWL_*Imp classes into the IFWL_* classes. (Closed)
Created 4 years, 2 months ago by dsinclair
Modified 4 years, 2 months ago
Reviewers: Lei Zhang, Wei Li
Base URL:
Comments: 6
This is Rietveld
408576698