Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Side by Side Diff: xfa/fwl/lightwidget/cfwl_combobox.cpp

Issue 2432423002: Merge the CFWL_*Imp classes into the IFWL_* classes. (Closed)
Patch Set: Review feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_combobox.h ('k') | xfa/fwl/lightwidget/cfwl_datetimepicker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/lightwidget/cfwl_combobox.h" 7 #include "xfa/fwl/lightwidget/cfwl_combobox.h"
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 } 241 }
242 242
243 CFWL_ComboBox::CFWL_ComboBoxDP::~CFWL_ComboBoxDP() {} 243 CFWL_ComboBox::CFWL_ComboBoxDP::~CFWL_ComboBoxDP() {}
244 244
245 FWL_Error CFWL_ComboBox::CFWL_ComboBoxDP::GetCaption( 245 FWL_Error CFWL_ComboBox::CFWL_ComboBoxDP::GetCaption(
246 IFWL_Widget* pWidget, 246 IFWL_Widget* pWidget,
247 CFX_WideString& wsCaption) { 247 CFX_WideString& wsCaption) {
248 return FWL_Error::Succeeded; 248 return FWL_Error::Succeeded;
249 } 249 }
250 250
251 int32_t CFWL_ComboBox::CFWL_ComboBoxDP::CountItems(IFWL_Widget* pWidget) { 251 int32_t CFWL_ComboBox::CFWL_ComboBoxDP::CountItems(const IFWL_Widget* pWidget) {
252 return m_ItemArray.size(); 252 return m_ItemArray.size();
253 } 253 }
254 254
255 IFWL_ListItem* CFWL_ComboBox::CFWL_ComboBoxDP::GetItem(IFWL_Widget* pWidget, 255 IFWL_ListItem* CFWL_ComboBox::CFWL_ComboBoxDP::GetItem(
256 int32_t nIndex) { 256 const IFWL_Widget* pWidget,
257 int32_t nIndex) {
257 if (nIndex < 0 || static_cast<size_t>(nIndex) >= m_ItemArray.size()) 258 if (nIndex < 0 || static_cast<size_t>(nIndex) >= m_ItemArray.size())
258 return nullptr; 259 return nullptr;
259 260
260 return m_ItemArray[nIndex].get(); 261 return m_ItemArray[nIndex].get();
261 } 262 }
262 263
263 int32_t CFWL_ComboBox::CFWL_ComboBoxDP::GetItemIndex(IFWL_Widget* pWidget, 264 int32_t CFWL_ComboBox::CFWL_ComboBoxDP::GetItemIndex(IFWL_Widget* pWidget,
264 IFWL_ListItem* pItem) { 265 IFWL_ListItem* pItem) {
265 auto it = std::find_if( 266 auto it = std::find_if(
266 m_ItemArray.begin(), m_ItemArray.end(), 267 m_ItemArray.begin(), m_ItemArray.end(),
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
378 return FWL_Error::Succeeded; 379 return FWL_Error::Succeeded;
379 } 380 }
380 381
381 FX_FLOAT CFWL_ComboBox::CFWL_ComboBoxDP::GetListHeight(IFWL_Widget* pWidget) { 382 FX_FLOAT CFWL_ComboBox::CFWL_ComboBoxDP::GetListHeight(IFWL_Widget* pWidget) {
382 return m_fMaxListHeight; 383 return m_fMaxListHeight;
383 } 384 }
384 385
385 CFWL_ComboBoxItem::CFWL_ComboBoxItem() : m_pDIB(nullptr), m_pData(nullptr) {} 386 CFWL_ComboBoxItem::CFWL_ComboBoxItem() : m_pDIB(nullptr), m_pData(nullptr) {}
386 387
387 CFWL_ComboBoxItem::~CFWL_ComboBoxItem() {} 388 CFWL_ComboBoxItem::~CFWL_ComboBoxItem() {}
OLDNEW
« no previous file with comments | « xfa/fwl/lightwidget/cfwl_combobox.h ('k') | xfa/fwl/lightwidget/cfwl_datetimepicker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698