Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2432413004:
[interpreter] Enable OSR for Ignition by default. (Closed)
|
Created:
4 years, 2 months ago by Michael Starzinger Modified:
4 years, 1 month ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com, Michael Hablich Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[interpreter] Enable OSR for Ignition by default.
This enables the on-stack replacement mechanism from Ignition bytecode
to TurboFan optimized code by default. The runtime profiler is now
allowed to arm OSR points in bytecode.
R=rmcilroy@chromium.org
Committed: https://crrev.com/0a94ef09d4fa77b9c6c72f9e3374bec372dbdeb9
Cr-Commit-Position: refs/heads/master@{#40911}
Patch Set 1 #Patch Set 2 : Rebased. #Patch Set 3 : Rebased. #Messages
Total messages: 26 (20 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [interpreter] Enable OSR for Ignition by default. This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R= ========== to ========== [interpreter] Enable OSR for Ignition by default. This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org ==========
mstarzinger@chromium.org changed reviewers: + rmcilroy@chromium.org
LGTM, thanks!
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/11945)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by mstarzinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rmcilroy@chromium.org Link to the patchset: https://codereview.chromium.org/2432413004/#ps40001 (title: "Rebased.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Enable OSR for Ignition by default. This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org ========== to ========== [interpreter] Enable OSR for Ignition by default. This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Enable OSR for Ignition by default. This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org ========== to ========== [interpreter] Enable OSR for Ignition by default. This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org Committed: https://crrev.com/0a94ef09d4fa77b9c6c72f9e3374bec372dbdeb9 Cr-Commit-Position: refs/heads/master@{#40911} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/0a94ef09d4fa77b9c6c72f9e3374bec372dbdeb9 Cr-Commit-Position: refs/heads/master@{#40911} |
