Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2432383005: [MD settings] help button in content settings site lists (Closed)
Patch Set: review changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 822fca2da8f6fc7c739215e20dd9a68b1aa96724..9f84a19799e2c4373690b5d1e1e575a67c186c9b 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -28,6 +28,10 @@
<dom-module id="settings-privacy-page">
<template>
<style include="settings-shared">
+ button[is='paper-icon-button-light'].icon-help {
+ background-image: url(../images/help_outline.svg);
+ }
+
/* TODO(dbeam): this is similar to a 1 line checkbox. Worth somehow
* combining? */
#metricsReporting {
@@ -186,6 +190,8 @@
<template is="dom-if" route-path="/siteSettings/automaticDownloads"
no-search>
<settings-subpage page-title="$i18n{siteSettingsAutomaticDownloads}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.AUTOMATIC_DOWNLOADS}}">
@@ -195,6 +201,8 @@
<template is="dom-if" route-path="/siteSettings/backgroundSync" no-search>
no-search>
<settings-subpage page-title="$i18n{siteSettingsBackgroundSync}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.BACKGROUND_SYNC}}">
@@ -203,6 +211,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/camera" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryCamera}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.CAMERA}}">
@@ -212,6 +222,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/cookies" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryCookies}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.COOKIES}}">
@@ -228,6 +240,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/images" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryImages}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.IMAGES}}">
@@ -236,6 +250,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/location" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryLocation}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.GEOLOCATION}}">
@@ -254,6 +270,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/javascript" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryJavascript}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.JAVASCRIPT}}">
@@ -262,6 +280,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/keygen" no-search>
<settings-subpage page-title="$i18n{siteSettingsKeygen}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.KEYGEN}}">
@@ -270,6 +290,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/microphone" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryMicrophone}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.MIC}}">
@@ -279,6 +301,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/notifications" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryNotifications}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.NOTIFICATIONS}}">
@@ -287,6 +311,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/flash" no-search>
<settings-subpage page-title="$i18n{siteSettingsFlash}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.PLUGINS}}">
@@ -295,6 +321,8 @@
</template>
<template is="dom-if" route-path="/siteSettings/popups" no-search>
<settings-subpage page-title="$i18n{siteSettingsCategoryPopups}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.POPUPS}}">
@@ -304,6 +332,8 @@
<template is="dom-if" route-path="/siteSettings/unsandboxedPlugins"
no-search>
<settings-subpage page-title="$i18n{siteSettingsUnsandboxedPlugins}">
+ <button class="icon-help subpage-title-extra"
+ is="paper-icon-button-light" on-tap="onHelpTap_"></button>
<site-settings-category
selected-site="{{selectedSite}}"
category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}">

Powered by Google App Engine
This is Rietveld 408576698