[MD settings] help button in content settings site lists

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 822fca2da8f6fc7c739215e20dd9a68b1aa96724..e04d7700f39e37abe908789712864fc1c9af166d 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -186,6 +186,8 @@
       <template is="dom-if" route-path="/siteSettings/automaticDownloads"
           no-search>
         <settings-subpage page-title="$i18n{siteSettingsAutomaticDownloads}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>

[dschuyler, 2016/10/20 23:27:46]

dpapad@ and I discussed a few ways this button could be added.
None of the options seemed amazing, so I chose one. This has 
the downside of repeating several times in this file, but imo
the other options were slightly less good.

           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.AUTOMATIC_DOWNLOADS}}">
@@ -195,6 +197,8 @@
       <template is="dom-if" route-path="/siteSettings/backgroundSync" no-search>
           no-search>
         <settings-subpage page-title="$i18n{siteSettingsBackgroundSync}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.BACKGROUND_SYNC}}">
@@ -203,6 +207,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/camera" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryCamera}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.CAMERA}}">
@@ -212,6 +218,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/cookies" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryCookies}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.COOKIES}}">
@@ -228,6 +236,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/images" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryImages}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.IMAGES}}">
@@ -236,6 +246,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/location" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryLocation}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.GEOLOCATION}}">
@@ -254,6 +266,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/javascript" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryJavascript}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.JAVASCRIPT}}">
@@ -262,6 +276,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/keygen" no-search>
         <settings-subpage page-title="$i18n{siteSettingsKeygen}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.KEYGEN}}">
@@ -270,6 +286,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/microphone" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryMicrophone}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.MIC}}">
@@ -279,6 +297,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/notifications" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryNotifications}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.NOTIFICATIONS}}">
@@ -287,6 +307,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/flash" no-search>
         <settings-subpage page-title="$i18n{siteSettingsFlash}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.PLUGINS}}">
@@ -295,6 +317,8 @@
       </template>
       <template is="dom-if" route-path="/siteSettings/popups" no-search>
         <settings-subpage page-title="$i18n{siteSettingsCategoryPopups}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.POPUPS}}">
@@ -304,6 +328,8 @@
       <template is="dom-if" route-path="/siteSettings/unsandboxedPlugins"
           no-search>
         <settings-subpage page-title="$i18n{siteSettingsUnsandboxedPlugins}">
+          <button class="icon-help subpage-title-extra"
+              is="paper-icon-button-light" on-tap="onHelpTap_"></button>
           <site-settings-category
               selected-site="{{selectedSite}}"
               category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}">