Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: Source/devtools/front_end/OverridesSupport.js

Issue 243233002: [DevTools] Disable touch emulation on devices with touch input. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/OverridesSupport.js
diff --git a/Source/devtools/front_end/OverridesSupport.js b/Source/devtools/front_end/OverridesSupport.js
index c380086e299a5c79aa44b872d890ece3db135b36..50cb5d16d27cb78797a8582faeb5b09152fcf2c3 100644
--- a/Source/devtools/front_end/OverridesSupport.js
+++ b/Source/devtools/front_end/OverridesSupport.js
@@ -68,6 +68,15 @@ WebInspector.OverridesSupport.isInspectingDevice = function()
return !!WebInspector.queryParam("remoteFrontend");
}
+/**
+ * @return {boolean}
+ */
+WebInspector.OverridesSupport.hasTouchInputs = function()
+{
+ var target = WebInspector.targetManager.mainTarget();
pfeldman 2014/04/18 16:23:15 There is no main target. Please use activeTarget f
+ return !!target && target.hasTouchInputs;
+}
+
WebInspector.OverridesSupport.Events = {
OverridesWarningUpdated: "OverridesWarningUpdated",
HasActiveOverridesChanged: "HasActiveOverridesChanged",
@@ -527,7 +536,7 @@ WebInspector.OverridesSupport.prototype = {
_emulateTouchEventsChanged: function()
{
- if (WebInspector.OverridesSupport.isInspectingDevice() && WebInspector.settings.emulateTouchEvents.get())
+ if (WebInspector.OverridesSupport.hasTouchInputs() && WebInspector.settings.emulateTouchEvents.get())
return;
var emulateTouch = WebInspector.settings.emulateTouchEvents.get();

Powered by Google App Engine
This is Rietveld 408576698