[DevTools] Disable touch emulation on devices with touch input.

[DevTools] Disable touch emulation on devices with touch input.

Previously, we disabled it on mobile devices, which was not accurate.

BUG=337142
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172074

[dgozman, 2014-04-18 15:13:12]

Could you please take a look?

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ta...
File Source/devtools/front_end/Target.js (right):

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ta...
Source/devtools/front_end/Target.js:247: if (this._targets[i].isMainFrontend)
Main target is the one with |isMainFrontend|, right?

[pfeldman, 2014-04-18 16:23:14]

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorClient.h (right):

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorClient.h:60: virtual bool hasTouchInputs() {
return false; }
This is super strange: why would you leave core/ given that Settings contains
proper value.

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ov...
File Source/devtools/front_end/OverridesSupport.js (right):

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ov...
Source/devtools/front_end/OverridesSupport.js:76: var target =
WebInspector.targetManager.mainTarget();
There is no main target. Please use activeTarget for now.

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ta...
File Source/devtools/front_end/Target.js (right):

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ta...
Source/devtools/front_end/Target.js:244: mainTarget: function()
Remove

[dgozman, 2014-04-18 17:26:27]

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorClient.h (right):

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorClient.h:60: virtual bool hasTouchInputs() {
return false; }
On 2014/04/18 16:23:15, pfeldman wrote:
> This is super strange: why would you leave core/ given that Settings contains
> proper value.

It may be overriden, while we need the original value. See WebDevToolsAgentImpl.

[pfeldman, 2014-04-18 18:56:12]

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorClient.h (right):

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorClient.h:60: virtual bool hasTouchInputs() {
return false; }
It still seems like it can all be done within InspectorPageAgent.cpp or what do
I miss?

[dgozman, 2014-04-21 11:46:10]

PTAL

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorClient.h (right):

https://codereview.chromium.org/243233002/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorClient.h:60: virtual bool hasTouchInputs() {
return false; }
On 2014/04/18 18:56:12, pfeldman wrote:
> It still seems like it can all be done within InspectorPageAgent.cpp or what
do
> I miss?

Done.

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ta...
File Source/devtools/front_end/Target.js (right):

https://codereview.chromium.org/243233002/diff/1/Source/devtools/front_end/Ta...
Source/devtools/front_end/Target.js:244: mainTarget: function()
On 2014/04/18 16:23:15, pfeldman wrote:
> Remove

Done.

[pfeldman, 2014-04-21 12:34:00]

https://codereview.chromium.org/243233002/diff/20001/Source/web/WebDevToolsAg...
File Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/243233002/diff/20001/Source/web/WebDevToolsAg...
Source/web/WebDevToolsAgentImpl.cpp:395: m_originalDeviceSupportsTouch =
m_webViewImpl->page()->settings().deviceSupportsTouch();
Why is this not a part of Page agent?

[dgozman, 2014-04-21 13:25:46]

PTAL

https://codereview.chromium.org/243233002/diff/20001/Source/web/WebDevToolsAg...
File Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/243233002/diff/20001/Source/web/WebDevToolsAg...
Source/web/WebDevToolsAgentImpl.cpp:395: m_originalDeviceSupportsTouch =
m_webViewImpl->page()->settings().deviceSupportsTouch();
On 2014/04/21 12:34:00, pfeldman wrote:
> Why is this not a part of Page agent?

Moved most to the PageAgent.

[pfeldman, 2014-04-21 15:00:39]

lgtm

[dgozman, 2014-04-21 15:24:13]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-04-21 15:24:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/243233002/40001

[commit-bot: I haz the power, 2014-04-21 16:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-21 16:41:27]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_dbg

[dgozman, 2014-04-21 19:46:16]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-04-21 19:46:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dgozman@chromium.org/243233002/40001

[commit-bot: I haz the power, 2014-04-21 20:58:59]

Change committed as 172074