Implement 'local' mode in TypeResolverVisitor.

Implement 'local' mode in TypeResolverVisitor.

If we start resolution not from CompilationUnit, we need to put type
parameters into scopes. This is not implemented yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/38e2b55fff2e3dbd081dd66faecf1912f5e96414

[Brian Wilkerson, 2016-10-19 16:30:18]

lgtm

https://codereview.chromium.org/2432273003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2432273003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9817: if (node is FunctionBody) {
This like of is tests is kind of ugly, but if there isn't a better way to
structure the code consider using "else if".

[Paul Berry, 2016-10-19 16:37:49]

lgtm

https://codereview.chromium.org/2432273003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2432273003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9817: if (node is FunctionBody) {
On 2016/10/19 16:30:18, Brian Wilkerson wrote:
> This like of is tests is kind of ugly, but if there isn't a better way to
> structure the code consider using "else if".

Another possibility: create a little visitor which takes the appropriate action,
and use it to do the dispatch.

[scheglov, 2016-10-19 16:47:10]

https://codereview.chromium.org/2432273003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2432273003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:9817: if (node is FunctionBody) {
On 2016/10/19 16:30:18, Brian Wilkerson wrote:
> This like of is tests is kind of ugly, but if there isn't a better way to
> structure the code consider using "else if".

Done.

[scheglov, 2016-10-19 16:47:45]

Description was changed from

==========
Implement 'local' mode in TypeResolverVisitor.

If we start resolution not from CompilationUnit, we need to put type
parameters into scopes. This is not implemented yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Implement 'local' mode in TypeResolverVisitor.

If we start resolution not from CompilationUnit, we need to put type
parameters into scopes. This is not implemented yet.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/38e2b55fff2e3dbd081dd66faecf1912f5e96414
==========

[scheglov, 2016-10-19 16:47:46]

Committed patchset #2 (id:20001) manually as
38e2b55fff2e3dbd081dd66faecf1912f5e96414 (presubmit successful).