Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1800)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2432203003: [Predator] Run predator. (Closed)
Patch Set: Rebase. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/changelist_classifier.py ('k') | appengine/findit/crash/culprit.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index b3b8ca6b38a1a4920be3ed23ec7c9b4d69eaafe5..52ef7a4d10d9942ba325519923862938ac69ac76 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -19,8 +19,8 @@ from lib.gitiles import gitiles_repository
from model import analysis_status
-# TODO(http://crbug.com/659346): this needs complete coverage tests.
-def FinditForClientID(client_id):
+# TODO(http://crbug.com/659346): write complete coverage tests for this.
+def FinditForClientID(client_id, repository): # pragma: no cover
"""Construct a Findit object from a client id string specifying the class.
We cannot pass Findit objects to the various methods in
@@ -50,8 +50,7 @@ def FinditForClientID(client_id):
raise ValueError('FinditForClientID: '
'unknown or unsupported client %s' % client_id)
- return cls(gitiles_repository.GitilesRepository(
- http_client=HttpClientAppengine()))
+ return cls(repository)
# Some notes about the classes below, for people who are not familiar
@@ -90,7 +89,9 @@ class CrashBasePipeline(BasePipeline):
def __init__(self, client_id, crash_identifiers):
super(CrashBasePipeline, self).__init__(client_id, crash_identifiers)
self._crash_identifiers = crash_identifiers
- self._findit = FinditForClientID(client_id)
+ self._findit = FinditForClientID(
+ client_id,
+ gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
@property
def client_id(self): # pragma: no cover
« no previous file with comments | « appengine/findit/crash/changelist_classifier.py ('k') | appengine/findit/crash/culprit.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698