Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: appengine/findit/crash/changelist_classifier.py

Issue 2432203003: [Predator] Run predator. (Closed)
Patch Set: Fix flaky BadStatusLine exception. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/changelist_classifier.py
diff --git a/appengine/findit/crash/changelist_classifier.py b/appengine/findit/crash/changelist_classifier.py
index 1272025e4041fb4c417a241bcb8256ed5d8992f7..7dab4cf51e7f22ff2f4862177eefd60212cf1fd6 100644
--- a/appengine/findit/crash/changelist_classifier.py
+++ b/appengine/findit/crash/changelist_classifier.py
@@ -292,13 +292,13 @@ def FindMatchResults(dep_to_file_to_changelogs,
for dep, file_to_stack_infos in dep_to_file_to_stack_infos.iteritems():
file_to_changelogs = dep_to_file_to_changelogs[dep]
- repository.repo_url = stack_deps[dep].repo_url
for crashed_file_path, stack_infos in file_to_stack_infos.iteritems():
for touched_file_path, changelogs in file_to_changelogs.iteritems():
if not crash_util.IsSameFilePath(crashed_file_path, touched_file_path):
continue
+ repository.repo_url = stack_deps[dep].repo_url
stgao 2016/11/17 05:03:05 Why we want this to be in the inner for loop? Does
Sharu Jiang 2016/11/17 09:03:15 Since for many cases, the repo_url doesn't need to
blame = repository.GetBlame(touched_file_path,
stack_deps[dep].revision)

Powered by Google App Engine
This is Rietveld 408576698