Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2432203003: [Predator] Run predator. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/culprit.py » ('j') | appengine/findit/crash/culprit.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 9532858384a378b823d50d401baf93fd03345739..19cf56b65289c9b465ed7b36970cb04ef30e27e8 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -20,7 +20,7 @@ from model import analysis_status
# TODO(http://crbug.com/659346): write complete coverage tests for this.
-def FinditForClientID(client_id): # pragma: no cover
+def FinditForClientID(client_id, repository): # pragma: no cover
"""Construct a Findit object from a client id string specifying the class.
We cannot pass Findit objects to the various methods in
@@ -50,9 +50,7 @@ def FinditForClientID(client_id): # pragma: no cover
raise ValueError('FinditForClientID: '
'unknown or unsupported client %s' % client_id)
- return cls(
- gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()),
- CrashWrapperPipeline)
+ return cls(repository, CrashWrapperPipeline)
# Some notes about the classes below, for people who are not
@@ -80,7 +78,9 @@ class CrashBasePipeline(BasePipeline):
def __init__(self, client_id, crash_identifiers):
super(CrashBasePipeline, self).__init__(client_id, crash_identifiers)
self._crash_identifiers = crash_identifiers
- self._findit = FinditForClientID(client_id)
+ self._findit = FinditForClientID(
+ client_id,
+ gitiles_repository.GitilesRepository(http_client=HttpClientAppengine()))
@property
def client_id(self): # pragma: no cover
« no previous file with comments | « no previous file | appengine/findit/crash/culprit.py » ('j') | appengine/findit/crash/culprit.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698