[Predator] Run predator.

appengine/findit/util_scripts/git_checkout/local_git_repository.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 from urlparse import urlparse
 import subprocess
 import threading
 
@@ skipping 64 matching lines @@
 
     parsed_url = urlparse(repo_url)
     self._host = parsed_url.netloc
     # Remove the / in the front of path.
     self._repo_path = parsed_url.path[1:]
 
     self._CloneOrUpdateRepoIfNeeded()
 
   def _CloneOrUpdateRepoIfNeeded(self):
     """Clones repo, or update it if it didn't got updated before."""
-    if self.repo_url in LocalGitRepository._updated_repos:
-      return
+    with LocalGitRepository.lock:
+      if self.repo_url in LocalGitRepository._updated_repos:
+        return
 
-    with LocalGitRepository.lock:
       # Clone the repo if needed.
       if not os.path.exists(self.real_repo_path):
         try:
           subprocess.check_call(['git', 'clone',
                                  self.repo_url, self.real_repo_path])
         except subprocess.CalledProcessError as e:  # pragma: no cover.
-          logging.error('Exception while cloning %s: %s', self.repo_url, e)
-          return
+          raise Exception(
+              'Exception while cloning %s: %s' % (self.repo_url, e))
       # Update repo if it's already cloned.
       else:
         try:
           # Disable verbose of cd and git pull.
           with open(os.devnull, 'w') as null_handle:
             subprocess.check_call(
                 'cd %s && git pull' % self.real_repo_path,
                 stdout=null_handle, stderr=null_handle, shell=True)
         except subprocess.CalledProcessError as e:  # pragma: no cover.
-          logging.error('Exception while updating %s: %s', self.repo_path, e)
-          return
+          raise Exception(
+              'Exception while updating %s: %s' % (self.repo_path, e))
 
       LocalGitRepository._updated_repos.add(self.repo_url)
 
   def _GetFinalCommand(self, command, utc=False):
     # Change local time to utc time.
     if utc:
       command = 'TZ=UTC %s --date=format-local:"%s"' % (
                 command, local_git_parsers.DATETIME_FORMAT)
     return 'cd %s && %s' % (self.real_repo_path, command)
 
@@ skipping 18 matching lines @@
     """Returns the diff of the given revision."""
     command = ('git log --format="" --max-count=1 %s' %
                ConvertRemoteCommitToLocal(revision))
     if path:
       command += ' -p %s' % path
     output = script_util.GetCommandOutput(self._GetFinalCommand(command))
     return self.diff_parser(output)
 
   def GetBlame(self, path, revision):
     """Returns blame of the file at ``path`` of the given revision."""
-    command = 'git blame --incremental %s %s' % (
-        path, ConvertRemoteCommitToLocal(revision))
+    command = 'git blame --incremental %s -- %s' % (
+        ConvertRemoteCommitToLocal(revision), path)
     output = script_util.GetCommandOutput(self._GetFinalCommand(command))
     return self.blame_parser(output, path, revision)
 
   def GetSource(self, path, revision):
     """Returns source code of the file at ``path`` of the given revision."""
     # Check whether the requested file exist or not.
     command = 'git show %s:%s' % (ConvertRemoteCommitToLocal(revision), path)
     output = script_util.GetCommandOutput(self._GetFinalCommand(command))
     return output