[Predator] Run predator.

appengine/findit/crash/test/crash_testcase.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import re
 
 from google.appengine.api import users
 
 from common.findit_testcase import FinditTestCase
+from common import retry_http_client
 from lib.gitiles.change_log import ChangeLog
 from model.crash.crash_config import CrashConfig
 
 
 DEFAULT_CONFIG_DATA = {
     'fracas': {
         'analysis_result_pubsub_topic': 'projects/project-name/topics/name',
         'supported_platform_list_by_channel': {
             'canary': ['win', 'mac', 'linux'],
             'supported_channel': ['supported_platform'],
@@ skipping 53 matching lines @@
     'committer_time': 'Thu Mar 31 21:28:39 2016',
     'commit_url':
         'https://repo.test/+/1',
     'code_review_url': 'https://codereview.chromium.org/3281',
     'committer_name': 'example@chromium.org',
     'revision': '1',
     'reverted_revision': None
 })
 
 
+class MockHttpClient(retry_http_client.RetryHttpClient):  # pragma: no cover.
+
+  def __init__(self):
+    super(MockHttpClient, self).__init__()
+
+  def _Get(self, url, *_):
+    pass
+
+  def _Post(self, *_):
+    pass
+
+  def _Put(self, *_):
+    pass
+
+
 class CrashTestCase(FinditTestCase):  # pragma: no cover.
 
   def setUp(self):
     super(CrashTestCase, self).setUp()
     CrashConfig.Get().Update(
         users.User(email='admin@chromium.org'), True, **DEFAULT_CONFIG_DATA)
+    # A fake repository, needed by the Findit constructor. We should never
+    # go over the wire (e.g., in the call to ScheduleNewAnalysis below),
+    # and this helps ensure that.

[stgao, 2016/11/14 21:34:12]

what's this for?

[Sharu Jiang, 2016/11/15 02:21:47]

This was accidentally pasted... deleted in following patch.

 
   def GetDummyChangeLog(self):
     return DUMMY_CHANGELOG
+
+  def GetMockHttpClient(self):
+    return MockHttpClient()

[stgao, 2016/11/14 21:34:12]

Why not just use a unittest.mock.Mock object?

[Sharu Jiang, 2016/11/15 02:21:47]

I think it's better that MockHttpClient is a instance of RetryHttpClient.

[stgao, 2016/11/17 05:03:05]

Why it is better? What's the benefit? Why a unittest.mock.Mock is insufficient?