[Predator] Run predator.

appengine/findit/lib/gitiles/test/repo_util_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import StringIO
 import subprocess
 from testing_utils import testing
 import textwrap
 import urllib2
 
 from lib.gitiles import repo_util
+from lib.cache_decorator import LocalCacher
 
 
 class RepoUtilTest(testing.AppengineTestCase):
 
   def testExtractCommitPositionAndCodeReviewUrl(self):
     testcases = [
         {
             'message':
                 'balabala...\n'
                 '\n'
@@ skipping 111 matching lines @@
 
     reverted_revision = repo_util.GetRevertedRevision(message)
     self.assertIsNone(reverted_revision)
 
   def testGetLocalGitCommandOutput(self):
     class _MockProcess(object):
       def __init__(self, command, *_):
         self.command = command
 
       def communicate(self, *_):
-        return self.command, 'dummy'
+        return self.command, 'error'
 
       @property
       def returncode(self):
         if self.command == 'dummy':

[wrengr, 2016/11/01 22:07:52]

nit: would be cleaner to ``return 1 if ... else 0``

[Sharu Jiang, 2016/11/11 23:10:26]

Done.

           return 1
 
         return 0
 
     def _MockPopen(command, **_):

[wrengr, 2016/11/01 22:07:52]

nit: would be cleaner to inline this as a lambda.

[Sharu Jiang, 2016/11/11 23:10:26]

Done.

       return _MockProcess(command)
 
     self.mock(subprocess, 'Popen', _MockPopen)
+    self.mock(LocalCacher, 'Get', lambda *_: None)
     output = repo_util.GetCommandOutput('command')
     self.assertEqual(output, 'command')
 
     output = repo_util.GetCommandOutput('dummy')
     self.assertEqual(output, None)