Issue 2432183003: Make visibleLength/visibleOffset informative.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2432183003: Make visibleLength/visibleOffset informative. (Closed)

Created:
4 years, 2 months ago by Paul Berry

Modified:
4 years, 2 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, vsm

Target Ref:
refs/heads/master

Visibility:
Public.

Make visibleLength/visibleOffset informative. These summary fields are related to source offsets, so they are affected by minute changes to the source code that don't affect its API; therefore they should be marked as "@informative" so that they don't appear in API summaries. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/84ec7f01c060ee0a5e423c58a11707a4e3a60045

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/summary/format.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	pkg/analyzer/lib/src/summary/idl.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 2 months ago (2016-10-19 21:24:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
84ec7f01c060ee0a5e423c58a11707a4e3a60045 (presubmit successful).