Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2432163006: Show/Hide the shelf when showing/hiding IME menu. (Closed)

Created:
4 years, 2 months ago by Azure Wei
Modified:
4 years, 1 month ago
Reviewers:
tdanderson
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show/Hide the shelf when showing/hiding IME menu. If the shelf is auto-hidden, show the opt-in IME menu with accelerator 'Alt+Shilf+K', the IME menu bubble cannot be oped right (it opens half off the screen, shifted to the right). We should notify to bring out the shelf before showing the IME menu. When closing the opt-in IME menu with 'Esc' key, the shelf cannot be auto hidden immediately. We should notify the auto hide state changed to auto hide the shelf. BUG=642423 TEST=Verified on local build. Committed: https://crrev.com/2fdfd846d4d238778f39adaa203c41dd90e39dda Cr-Commit-Position: refs/heads/master@{#427223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Azure Wei
Please review this CL. Thanks!
4 years, 2 months ago (2016-10-21 07:01:28 UTC) #3
tdanderson
lgtm
4 years, 1 month ago (2016-10-24 14:35:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2432163006/1
4 years, 1 month ago (2016-10-25 00:52:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 01:38:45 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 01:41:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fdfd846d4d238778f39adaa203c41dd90e39dda
Cr-Commit-Position: refs/heads/master@{#427223}

Powered by Google App Engine
This is Rietveld 408576698