src/inspector/v8-inspector-session-impl.cc - Issue 2432163004: Avoid using stale InspectedContext pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/inspector/v8-inspector-session-impl.cc

Issue 2432163004: Avoid using stale InspectedContext pointers (Closed)

Patch Set: Fix nits Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/inspector/v8-inspector-session-impl.cc

diff --git a/src/inspector/v8-inspector-session-impl.cc b/src/inspector/v8-inspector-session-impl.cc

index 9a0f652c4ca4ae228d33083a8c6711b998d90dc6..c3d3f48f00fb52f6b65bdd1c5f0f26dd96b83468 100644

--- a/src/inspector/v8-inspector-session-impl.cc

+++ b/src/inspector/v8-inspector-session-impl.cc

@@ -187,8 +187,7 @@ InjectedScript* V8InspectorSessionImpl::findInjectedScript(

const std::unique_ptr<InspectedContext>& context = contextsIt->second;

if (!context->getInjectedScript()) {

- context->createInjectedScript();

- if (!context->getInjectedScript()) {

+ if (!context->createInjectedScript()) {

*errorString = "Cannot access specified execution context";

return nullptr;

}