Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/inspector/v8-inspector-session-impl.cc

Issue 2432163004: Avoid using stale InspectedContext pointers (Closed)
Patch Set: Add tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/inspected-context.cc ('k') | test/inspector/console/destroy-context-during-log.js » ('j') | test/inspector/console/destroy-context-during-log.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-inspector-session-impl.cc
diff --git a/src/inspector/v8-inspector-session-impl.cc b/src/inspector/v8-inspector-session-impl.cc
index 9a0f652c4ca4ae228d33083a8c6711b998d90dc6..c3d3f48f00fb52f6b65bdd1c5f0f26dd96b83468 100644
--- a/src/inspector/v8-inspector-session-impl.cc
+++ b/src/inspector/v8-inspector-session-impl.cc
@@ -187,8 +187,7 @@ InjectedScript* V8InspectorSessionImpl::findInjectedScript(
const std::unique_ptr<InspectedContext>& context = contextsIt->second;
if (!context->getInjectedScript()) {
- context->createInjectedScript();
- if (!context->getInjectedScript()) {
+ if (!context->createInjectedScript()) {
*errorString = "Cannot access specified execution context";
return nullptr;
}
« no previous file with comments | « src/inspector/inspected-context.cc ('k') | test/inspector/console/destroy-context-during-log.js » ('j') | test/inspector/console/destroy-context-during-log.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698