Avoid using stale InspectedContext pointers

test/inspector/console/destroy-context-during-log.js

+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const expression = `
+  Object.defineProperty(Object.prototype, 'RemoteObject', {
+    configurable: true,
+    set(v) {
+      delete Object.prototype.RemoteObject;
+      this.RemoteObject = v;
+
+      detachInspector();
+      setTimeout(function() {
+        // Attach the inspector again for the sake of establishing a
+        // communication channel with the frontend test runner.
+        attachInspector();
+        console.log("End of test");
+      }, 0);
+    },
+  });
+
+  // Before the whole script runs, the inspector is already attached.
+  // Re-attach the inspector and trigger the console API to make sure that the
+  // injected inspector script runs again (and triggers the above setter).
+  detachInspector();
+  attachInspector();
+  console.log("First inspector activity after attaching inspector");
+`;
+
+Protocol.Runtime.enable();
+Protocol.Runtime.evaluate({
+  expression,

[kozy, 2016/10/21 15:06:53]

Looks suspicious, expression: expression?

[robwu, 2016/10/21 20:32:45]

Nope, this is ES6 syntax. It is a shorthand for expression: expression.
I've changed it to "expression: expression" in case you require ES5 syntax (the
"const" at the top of this file is also ES6 syntax), but please let me know if
you would or would not accept such modern JS syntax in future patches, if any.

[kozy, 2016/10/21 20:41:26]

Thanks,
For object literals we prefer ES5 syntax without shorthands. Scope variables are
okey. As well as one line arrow functions and template literals for multiline
strings.

[robwu, 2016/10/21 20:47:36]

Is this tribal knowledge, or is there a public coding style document or e.g. a
set of rules that I can add to my .eslintrc or .jshintrc?

+  silent: true,

[kozy, 2016/10/21 15:06:53]

You don't really need it and it'll hide exception in expression if it happens.

[robwu, 2016/10/21 20:32:45]

Done.

+  returnByValue: false,

[kozy, 2016/10/21 15:06:53]

it's false by default, you can just pass { expression: expression }

[robwu, 2016/10/21 20:32:45]

Done.

+});
+
+Protocol.Runtime.onConsoleAPICalled(function(result) {
+  InspectorTest.logObject(result.params.args[0]);
+  if (result.params.args[0].value == "End of test") {
+    InspectorTest.completeTest();
+  }
+});