[turbofan] Don't introduce PlainPrimitiveToNumber for String inputs.

[turbofan] Don't introduce PlainPrimitiveToNumber for String inputs.

During JSTypedLowering we can decide to insert PlainPrimitiveToNumber
operators on the inputs to still utilize pure Number operators, when
the type feedback on the numeric binary operation is NumberOrOddball.
However that is not beneficial if the inputs can be Strings, that is
we cannot statically rule out String based on input type, as that
inserts a ToNumber stub call into the hot code path.

This repairs the NavierStokes regression with Ignition on Octane.

R=jarin@chromium.org

Committed: https://crrev.com/09410621f98bcf9fd022c4f183457ada6342c7fa
Cr-Commit-Position: refs/heads/master@{#40427}

[Benedikt Meurer, 2016-10-19 09:00:17]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 09:00:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-10-19 09:01:54]

lgtm

[Benedikt Meurer, 2016-10-19 09:02:21]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-10-19 09:02:24]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-10-19 09:02:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-10-19 10:33:19]

Description was changed from

==========
[turbofan] Don't introduce PlainPrimitiveToNumber for String inputs.

During JSTypedLowering we can decide to insert PlainPrimitiveToNumber
operators on the inputs to still utilize pure Number operators, when
the type feedback on the numeric binary operation is NumberOrOddball.
However that is not beneficial if the inputs can be Strings, that is
we cannot statically rule out String based on input type, as that
inserts a ToNumber stub call into the hot code path.

This repairs the NavierStokes regression with Ignition on Octane.

R=jarin@chromium.org
==========

to

==========
[turbofan] Don't introduce PlainPrimitiveToNumber for String inputs.

During JSTypedLowering we can decide to insert PlainPrimitiveToNumber
operators on the inputs to still utilize pure Number operators, when
the type feedback on the numeric binary operation is NumberOrOddball.
However that is not beneficial if the inputs can be Strings, that is
we cannot statically rule out String based on input type, as that
inserts a ToNumber stub call into the hot code path.

This repairs the NavierStokes regression with Ignition on Octane.

R=jarin@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/09410621f98bcf9fd022c4f183457ada634...
==========

[Benedikt Meurer, 2016-10-19 10:33:20]

Committed patchset #1 (id:1) manually as
09410621f98bcf9fd022c4f183457ada6342c7fa (presubmit successful).

[commit-bot: I haz the power, 2016-11-17 22:06:02]

Description was changed from

==========
[turbofan] Don't introduce PlainPrimitiveToNumber for String inputs.

During JSTypedLowering we can decide to insert PlainPrimitiveToNumber
operators on the inputs to still utilize pure Number operators, when
the type feedback on the numeric binary operation is NumberOrOddball.
However that is not beneficial if the inputs can be Strings, that is
we cannot statically rule out String based on input type, as that
inserts a ToNumber stub call into the hot code path.

This repairs the NavierStokes regression with Ignition on Octane.

R=jarin@chromium.org

Committed:
https://chromium.googlesource.com/v8/v8/+/09410621f98bcf9fd022c4f183457ada634...
==========

to

==========
[turbofan] Don't introduce PlainPrimitiveToNumber for String inputs.

During JSTypedLowering we can decide to insert PlainPrimitiveToNumber
operators on the inputs to still utilize pure Number operators, when
the type feedback on the numeric binary operation is NumberOrOddball.
However that is not beneficial if the inputs can be Strings, that is
we cannot statically rule out String based on input type, as that
inserts a ToNumber stub call into the hot code path.

This repairs the NavierStokes regression with Ignition on Octane.

R=jarin@chromium.org

Committed: https://crrev.com/09410621f98bcf9fd022c4f183457ada6342c7fa
Cr-Commit-Position: refs/heads/master@{#40427}
==========