[Findit] Add local_git_repository

appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py

Index: appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
diff --git a/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py b/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
new file mode 100644
index 0000000000000000000000000000000000000000..284c8a4f434d16a719a218ae14909aa3f262ac14
--- /dev/null
+++ b/appengine/findit/util_scripts/git_checkout/test/local_git_repository_test.py
@@ -0,0 +1,258 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from datetime import datetime
+import pytz
+import os
+import subprocess
+import textwrap
+
+from testing_utils import testing
+
+from git_checkout import local_git_repository
+from lib.gitiles import blame
+from lib.gitiles import change_log
+import script_util
+
+
+class LocalGitRepositoryTest(testing.AppengineTestCase):
+
+  def setUp(self):
+    super(LocalGitRepositoryTest, self).setUp()
+    self.mock(subprocess, 'check_call', lambda *args, **kwargs: None)
+    self.local_repo = local_git_repository.LocalGitRepository(
+        'https://repo/path')
+
+  def testCloneOrUpdateRepoIfRepoNotExists(self):
+    self.mock(os.path, 'exists', lambda path: False)
+    repo = local_git_repository.LocalGitRepository('httt://repo1')

[wrengr, 2016/11/08 19:32:37]

Just to be sure, is that supposed to be "httt" rather than "http"/"https"? If
so, then probably should have a comment saying so (and why)

[Sharu Jiang, 2016/11/11 00:29:06]

Sorry, this is typo...

+    repo._CloneOrUpdateRepoIfNeeded()
+    self.assertTrue(self.local_repo.repo_url in
+                    local_git_repository.LocalGitRepository._updated_repos)
+
+  def testCloneOrUpdateRepoIfRepoExistsButNotUpdated(self):
+    self.mock(os.path, 'exists', lambda path: True)
+    repo = local_git_repository.LocalGitRepository('httt://repo2')

[wrengr, 2016/11/08 19:32:37]

ditto

[Sharu Jiang, 2016/11/11 00:29:06]

Done.

+    repo._CloneOrUpdateRepoIfNeeded()
+    self.assertTrue(self.local_repo.repo_url in
+                    local_git_repository.LocalGitRepository._updated_repos)
+
+  def testRepoUrlSetter(self):
+    def _MockCloneOrUpdateRepoIfNeeded(*_):
+      if not hasattr(_MockCloneOrUpdateRepoIfNeeded, 'clone_or_update_count'):
+        _MockCloneOrUpdateRepoIfNeeded.clone_or_update_count = 0
+      _MockCloneOrUpdateRepoIfNeeded.clone_or_update_count += 1
+
+    repo = local_git_repository.LocalGitRepository()
+    self.mock(repo, '_CloneOrUpdateRepoIfNeeded',
+              _MockCloneOrUpdateRepoIfNeeded)
+
+    repo.repo_url = 'https://repo/path'
+    self.assertEqual(_MockCloneOrUpdateRepoIfNeeded.clone_or_update_count, 1)
+
+    repo.repo_url = 'https://repo/path'
+    self.assertEqual(_MockCloneOrUpdateRepoIfNeeded.clone_or_update_count, 1)
+
+    repo.repo_url = 'https://repo/path2'
+    self.assertEqual(_MockCloneOrUpdateRepoIfNeeded.clone_or_update_count, 2)
+
+    repo.repo_url = None
+    self.assertIsNone(repo.repo_url)
+
+  def testGetChangeLog(self):
+    output = textwrap.dedent(
+        """
+        commit revision
+        tree tree_revision
+        parents parent_revision
+
+        author Test
+        author-mail test@google.com
+        author-time 2016-07-13 20:37:06
+
+        committer Test
+        committer-mail test@google.com
+        committer-time 2016-07-13 20:37:06
+
+        --Message start--
+        blabla
+        --Message end--
+
+        :100644 100644 25f95f c766f1 M      src/a/b.py
+        """
+    )
+
+    expected_changelog = change_log.ChangeLog(
+        'Test', 'test@google.com', datetime(2016, 7, 13, 20, 37, 6),
+        'Test', 'test@google.com', datetime(2016, 7, 13, 20, 37, 6),
+        'revision', None, 'blabla', [change_log.FileChangeInfo(
+            'modify', 'src/a/b.py', 'src/a/b.py')],
+        'https://repo/path/+/revision', None, None)
+    self.mock(script_util, 'GetCommandOutput', lambda *_: output)
+    self.assertEqual(self.local_repo.GetChangeLog('revision').ToDict(),
+                     expected_changelog.ToDict())
+
+  def testGetChangeLogNoneCommandOutput(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: None)
+    self.assertIsNone(self.local_repo.GetChangeLog('revision'))
+
+  def testGetChangeLogs(self):
+    output = textwrap.dedent(
+        """
+        **Changelog start**
+        commit rev1
+        tree 27b0421273ed4aea25e497c6d26d9c7db6481852
+        parents rev22c9e
+
+        author author1
+        author-mail author1@chromium.org
+        author-time 2016-06-02 10:55:38
+
+        committer Commit bot
+        committer-mail commit-bot@chromium.org
+        committer-time 2016-06-02 10:57:13
+
+        --Message start--
+        Message 1
+        --Message end--
+
+        :100644 100644 28e117 f12d3 D      a/b.py
+
+
+        **Changelog start**
+        commit rev2
+        tree d22d3786e135b83183cfeba5f3d8913959f56299
+        parents ac7ee4ce7b8d39b22a710c58d110e0039c11cf9a
+
+        author author2
+        author-mail author2@chromium.org
+        author-time 2016-06-02 10:53:03
+
+        committer Commit bot
+        committer-mail commit-bot@chromium.org
+        committer-time 2016-06-02 10:54:14
+
+        --Message start--
+        Message 2
+        --Message end--
+
+        :100644 100644 7280f df186 A      b/c.py
+        """
+    )
+
+    expected_changelogs = [
+        change_log.ChangeLog('author1',

[wrengr, 2016/11/08 19:32:37]

personally I'd linewrap after the opening parens, so that you're not forced to
wrap the message fields

[Sharu Jiang, 2016/11/11 00:29:06]

Done.

+                             'author1@chromium.org',
+                             datetime(2016, 6, 2, 10, 55, 38),
+                             'Commit bot',
+                             'commit-bot@chromium.org',
+                             datetime(2016, 6, 2, 10, 57, 13),
+                             'rev1', None,
+                             'Message 1', [change_log.FileChangeInfo(
+                                 'delete', 'a/b.py', None)],
+                             'https://repo/path/+/rev1', None, None),
+        change_log.ChangeLog('author2',
+                             'author2@chromium.org',
+                             datetime(2016, 6, 2, 10, 53, 3),
+                             'Commit bot',
+                             'commit-bot@chromium.org',
+                             datetime(2016, 6, 2, 10, 54, 14),
+                             'rev2', None,
+                             'Message 2', [change_log.FileChangeInfo(
+                                 'add', None, 'b/c.py')],
+                             'https://repo/path/+/rev2', None, None),
+    ]
+
+    self.mock(script_util, 'GetCommandOutput', lambda *_: output)
+    changelogs = self.local_repo.GetChangeLogs('rev0', 'rev2')
+    for changelog, expected_changelog in zip(changelogs, expected_changelogs):
+      self.assertEqual(changelog.ToDict(), expected_changelog.ToDict())

[wrengr, 2016/11/08 19:32:37]

Should compare the CL objects directly via __eq__. Feel free to add a todo and
make that change in a separate cl

[Sharu Jiang, 2016/11/11 00:29:06]

Done.

+
+  def testGetChangeLogsNoneCommandOutput(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: None)
+    self.assertIsNone(self.local_repo.GetChangeLogs('rev0', 'rev2'))
+
+  def testGetChangeDiff(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: 'diff')
+    self.assertEqual(self.local_repo.GetChangeDiff('rev'), 'diff')
+    self.assertEqual(self.local_repo.GetChangeDiff('rev', 'file_path'), 'diff')
+
+  def testGetChangeDiffNoneCommandOutput(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: None)
+    self.assertIsNone(self.local_repo.GetChangeDiff('rev'))
+
+  def testGetBlame(self):
+    output = textwrap.dedent(
+        """
+        revision_hash 18 18 3
+        author test@google.com
+        author-mail <test@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>
+        author-time 2013-03-11 17:13:36
+        committer test@google.com
+        committer-mail <test@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81>
+        committer-time 2013-03-11 17:13:36
+        summary add (mac) test for ttcindex in SkFontStream
+        previous fe7533eebe777cc66c7f8fa7a03f00572755c5b4 src/core/SkFont.h
+        filename src/core/SkFont.h
+                     *  blabla line 1
+        revision_hash 19 19
+                     *  blabla line 2
+        revision_hash 20 20
+                     *  blabla line 3
+        """
+    )
+    self.mock(script_util, 'GetCommandOutput', lambda *_: output)
+    expected_regions = [blame.Region(18, 3, 'revision_hash', 'test@google.com',
+                                     'test@google.com',
+                                     datetime(2013, 03, 11, 17, 13, 36))]
+    expected_blame = blame.Blame('src/core/SkFont.h', 'rev')
+    for expected_region in expected_regions:
+      expected_blame.AddRegion(expected_region)
+
+    blame_result = self.local_repo.GetBlame('src/core/SkFont.h', 'rev')
+    self.assertTrue(blame_result.revision, expected_blame.revision)
+    self.assertTrue(blame_result.path, expected_blame.path)
+    # TODO(katesonia): Switch to use __eq__ in blame.
+    for region, expected_region in zip(blame_result, expected_blame):
+      self.assertTrue(region.ToDict(), expected_region.ToDict())
+
+  def testGetBlameNoneCommandOutput(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: None)
+    self.assertIsNone(self.local_repo.GetBlame('src/core/SkFont.h', 'rev'))
+
+  def testGetSource(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: 'source')
+    self.assertIsNone(self.local_repo.GetSource('file_path', 'rev'))
+    self.mock(os.path, 'isfile', lambda path: True)
+    self.assertEqual(self.local_repo.GetSource('file_path', 'rev'), 'source')
+
+  def testGetSourceNoneCommandOutput(self):
+    self.mock(script_util, 'GetCommandOutput', lambda *_: None)
+    self.mock(os.path, 'isfile', lambda path: True)
+    self.assertIsNone(self.local_repo.GetSource('file_path', 'rev'))
+
+  def testGetLocalGitCommandOutput(self):
+    class _MockProcess(object):
+      def __init__(self, command, *_):
+        self.command = command
+
+      def communicate(self, *_):
+        return self.command, 'dummy'
+
+      @property
+      def returncode(self):
+        if self.command == 'dummy':

[wrengr, 2016/11/08 19:32:37]

Can be made a ``return 1 if ... else 0`` oneliner, like in
util_scripts/test/script_util_test.py

[Sharu Jiang, 2016/11/11 00:29:06]

Done.

+          return 1
+
+        return 0
+
+    def _MockPopen(command, **_):
+      return _MockProcess(command)
+
+    self.mock(subprocess, 'Popen', _MockPopen)
+    output = script_util.GetCommandOutput('command')
+    self.assertEqual(output, 'command')
+
+    output = script_util.GetCommandOutput('dummy')
+    self.assertEqual(output, None)