Issue 24321002: MIPS: replace RegExpCEntryStub with DirectCEntryStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24321002: MIPS: replace RegExpCEntryStub with DirectCEntryStub. (Closed)

Created:
7 years, 3 months ago by kilvadyb

Modified:
7 years, 2 months ago

Reviewers:
kisg, Paul Lind, palfia, danno, Jakob Kummerow

CC:
v8-dev

Base URL:
git@github.com:paul99/v8m-rb.git@master

Visibility:
Public.

More Reviews

Description

MIPS: replace RegExpCEntryStub with DirectCEntryStub. Port r16618 (0eebc593) Original commit message: RegExpCEntryStub is therefore removed. BUG=none TEST=none

Patch Set 1 #

Patch Set 2 : comment added. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -88 lines)			Patch
M	src/mips/code-stubs-mips.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1	2 chunks	+13 lines, -28 lines	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View		3 chunks	+45 lines, -36 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

LGTM. This is an alternate implementation of https://codereview.chromium.org/24233003/, which cleans up some MIPS-specific argument slot ...

7 years, 2 months ago (2013-09-25 00:53:15 UTC) #1

Committed as r16927.

Expand Messages | Collapse Messages