third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2432083003: Add a nbsp at the the end of the text when the next text has a leading space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2432083003: Add a nbsp at the the end of the text when the next text has a leading space. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/inserting/insert-space.html ('K') | « third_party/WebKit/LayoutTests/editing/inserting/insert-space.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index b3b12ac43eb61b64e270f190d3d1071fc1e5d516..5cadbda9a7df38083c8a8cdac41f9362768599e2 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -871,7 +871,8 @@ void CompositeEditCommand::rebalanceWhitespaceOnTextSubstring(Text* textNode,

// See http://crbug.com/310149

const bool nextSiblingIsTextNode =

textNode->nextSibling() && textNode->nextSibling()->isTextNode() &&

- toText(textNode->nextSibling())->data().length();

+ toText(textNode->nextSibling())->data().length() &&

+ toText(textNode->nextSibling())->data()[0] != ' ';

const bool shouldEmitNBSPbeforeEnd =

(isEndOfParagraph(visibleDownstreamPos) ||

(unsigned)downstream == text.length()) &&