Mojofy unittests: ServiceWorkerContextTest

Mojofy unittests: ServiceWorkerContextTest

This patch wraps SWContextTest by MojoServiceWorkerTestP with fixing some
expectations related to IPCs. This also mojofies SWContextRecoveryTest which
already used the parameterized test.

BUG=629701
TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerContextRecoveryTest/*"
TEST=./out/Debug/content_unittests -f --gtest_filter="ServiceWorkerContextTest/*"

Committed: https://crrev.com/b524cec853ee39350abf72e2829727d7f9ddde07
Cr-Commit-Position: refs/heads/master@{#426436}

[shimazu, 2016-10-19 03:41:50]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org

[shimazu, 2016-10-19 03:41:51]

ptal

[horo, 2016-10-19 04:50:09]

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_context_unittest.cc (right):

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_unittest.cc:186:
EXPECT_EQ(2UL, helper_->ipc_sink()->message_count());
Please check this using CreateAndRegisterMockInstanceClient.
- MockEmbeddedWorkerInstanceClient::StartWorker() is called once.
- MockEmbeddedWorkerInstanceClient::StopWorker() is called once.

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_unittest.cc:242:
EXPECT_EQ(1UL, helper_->ipc_sink()->message_count());
ditto

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_unittest.cc:294:
EXPECT_EQ(2UL, helper_->ipc_sink()->message_count());
ditto

[shimazu, 2016-10-20 05:08:45]

Updated. ptal again.

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_context_unittest.cc (right):

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_unittest.cc:186:
EXPECT_EQ(2UL, helper_->ipc_sink()->message_count());
On 2016/10/19 04:50:09, horo wrote:
> Please check this using CreateAndRegisterMockInstanceClient.
> - MockEmbeddedWorkerInstanceClient::StartWorker() is called once.
> - MockEmbeddedWorkerInstanceClient::StopWorker() is called once.

Done.

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_unittest.cc:242:
EXPECT_EQ(1UL, helper_->ipc_sink()->message_count());
On 2016/10/19 04:50:09, horo wrote:
> ditto

Done.

https://codereview.chromium.org/2432083002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_unittest.cc:294:
EXPECT_EQ(2UL, helper_->ipc_sink()->message_count());
On 2016/10/19 04:50:09, horo wrote:
> ditto

Done.

[horo, 2016-10-20 07:33:00]

lgtm with nits

https://chromiumcodereview.appspot.com/2432083002/diff/20001/content/browser/...
File content/browser/service_worker/service_worker_context_unittest.cc (right):

https://chromiumcodereview.appspot.com/2432083002/diff/20001/content/browser/...
content/browser/service_worker/service_worker_context_unittest.cc:173:
RecordableEmbeddedWorkerInstanceClient(
nit:
explicit

https://chromiumcodereview.appspot.com/2432083002/diff/20001/content/browser/...
content/browser/service_worker/service_worker_context_unittest.cc:197:
std::vector<Message> events_;
nit:
  DISALLOW_COPY_AND_ASSIGN(RecordableEmbeddedWorkerInstanceClient);

[shimazu, 2016-10-20 08:45:56]

Thanks, updated.

https://codereview.chromium.org/2432083002/diff/20001/content/browser/service...
File content/browser/service_worker/service_worker_context_unittest.cc (right):

https://codereview.chromium.org/2432083002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_unittest.cc:173:
RecordableEmbeddedWorkerInstanceClient(
On 2016/10/20 07:33:00, horo wrote:
> nit:
> explicit

Done.

https://codereview.chromium.org/2432083002/diff/20001/content/browser/service...
content/browser/service_worker/service_worker_context_unittest.cc:197:
std::vector<Message> events_;
On 2016/10/20 07:33:00, horo wrote:
> nit:
>   DISALLOW_COPY_AND_ASSIGN(RecordableEmbeddedWorkerInstanceClient);

Done.

[shimazu, 2016-10-20 08:46:07]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2016-10-20 08:46:07]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/2432083002/#ps40001
(title: "Added explicit and DISALLOW_COPY_AND_ASSIGN")

[commit-bot: I haz the power, 2016-10-20 08:46:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 09:47:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:16:50]

Description was changed from

==========
Mojofy unittests: ServiceWorkerContextTest

This patch wraps SWContextTest by MojoServiceWorkerTestP with fixing some
expectations related to IPCs. This also mojofies SWContextRecoveryTest which
already used the parameterized test.

BUG=629701
TEST=./out/Debug/content_unittests -f
--gtest_filter="ServiceWorkerContextRecoveryTest/*"
TEST=./out/Debug/content_unittests -f
--gtest_filter="ServiceWorkerContextTest/*"
==========

to

==========
Mojofy unittests: ServiceWorkerContextTest

This patch wraps SWContextTest by MojoServiceWorkerTestP with fixing some
expectations related to IPCs. This also mojofies SWContextRecoveryTest which
already used the parameterized test.

BUG=629701
TEST=./out/Debug/content_unittests -f
--gtest_filter="ServiceWorkerContextRecoveryTest/*"
TEST=./out/Debug/content_unittests -f
--gtest_filter="ServiceWorkerContextTest/*"

Committed: https://crrev.com/b524cec853ee39350abf72e2829727d7f9ddde07
Cr-Commit-Position: refs/heads/master@{#426436}
==========

[commit-bot: I haz the power, 2016-10-21 13:16:51]

Patchset 3 (id:??) landed as
https://crrev.com/b524cec853ee39350abf72e2829727d7f9ddde07
Cr-Commit-Position: refs/heads/master@{#426436}