Include scroll snap in scroll position used for sticky offset calculation.

Include scroll snap in scroll position used for sticky offset calculation.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/dc5dfbe3795799bca5bc856fd391b754afb775b0
Cr-Commit-Position: refs/heads/master@{#427161}

[flackr, 2016-10-20 20:03:41]

Description was changed from

==========
Don't snap after applying sticky offset.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
==========

to

==========
Don't snap after applying sticky offset.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[flackr, 2016-10-20 20:04:07]

flackr@chromium.org changed reviewers:
+ ajuma@chromium.org

[flackr, 2016-10-20 20:04:07]

PTAL, thanks!

[flackr, 2016-10-20 21:29:57]

On 2016/10/20 at 20:04:07, flackr wrote:
> PTAL, thanks!

Nevermind, as you pointed out snapping only applies to scrollable nodes so
already shouldn't be affecting position sticky. I will keep investigating.

[flackr, 2016-10-24 19:23:48]

Description was changed from

==========
Don't snap after applying sticky offset.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Include scroll snap in scroll position used for sticky offset calculation.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[flackr, 2016-10-24 19:25:55]

Hey,

I found the problem, the sticky offset calculation was using the node's scroll
offset but this offset doesn't include the scroll_snap used to snap to an
integer pixel offset.

Can you take another look? Thanks!

[ajuma, 2016-10-24 19:51:23]

On 2016/10/24 19:25:55, flackr wrote:
> Hey,
> 
> I found the problem, the sticky offset calculation was using the node's scroll
> offset but this offset doesn't include the scroll_snap used to snap to an
> integer pixel offset.
> 
> Can you take another look? Thanks!

lgtm

[flackr, 2016-10-24 19:52:09]

The CQ bit was checked by flackr@chromium.org

[commit-bot: I haz the power, 2016-10-24 19:52:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 21:44:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-24 21:46:07]

Description was changed from

==========
Include scroll snap in scroll position used for sticky offset calculation.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Include scroll snap in scroll position used for sticky offset calculation.

BUG=649111
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/dc5dfbe3795799bca5bc856fd391b754afb775b0
Cr-Commit-Position: refs/heads/master@{#427161}
==========

[commit-bot: I haz the power, 2016-10-24 21:46:07]

Patchset 2 (id:??) landed as
https://crrev.com/dc5dfbe3795799bca5bc856fd391b754afb775b0
Cr-Commit-Position: refs/heads/master@{#427161}