Make window.navigator property non replaceable

Make window.navigator property non replaceable

Make window.navigator property non replaceable non replaceable to match
the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#window

The new behavior also matches the behavior of Firefox 28 and IE11.

R=arv@chromium.org, tkent@chromium.org
BUG=364512
TEST=fast/dom/Window/get-set-properties.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172091

[arv (Not doing code reviews), 2014-04-18 18:44:01]

I'm not sure we want to change this. It will break code that uses these names
for global variables.

Also, these are replaceable in Firefox.

[Inactive, 2014-04-18 18:46:45]

On 2014/04/18 18:44:01, arv wrote:
> I'm not sure we want to change this. It will break code that uses these names
> for global variables.
> 
> Also, these are replaceable in Firefox.

Based on my testing, they are not replaceable in Firefox 28. I used this to
verify:
http://jsfiddle.net/QeL6a/1/

[Inactive, 2014-04-18 18:50:41]

I don't know how likely it is that real sites are using "navigator" or "history"
as variable names if this fails on Firefox and IE already.

[arv (Not doing code reviews), 2014-04-18 18:58:45]

I take it back. I was testing in Chrome... damn all these browsers that
look identical.

LGTM


On Fri, Apr 18, 2014 at 2:50 PM, <ch.dumez@samsung.com> wrote:

> I don't know how likely it is that real sites are using "navigator" or
> "history"
> as variable names if this fails on Firefox and IE already.
>
> https://codereview.chromium.org/243203002/
>



-- 
erik

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[arv (Not doing code reviews), 2014-04-18 19:33:16]

LGTM

[tkent, 2014-04-20 23:56:28]

lgtm

[commit-bot: I haz the power, 2014-04-20 23:56:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/243203002/20001

[commit-bot: I haz the power, 2014-04-21 01:13:51]

Change committed as 172006

[Inactive, 2014-04-21 16:43:46]

This patch was reverted for breaking the PlatformAppBrowserTest.Restrictions
browser test. I am relanding only the change to window.navigator as the
window.history change is the one causing the problem (and will take more time to
address).

[Inactive, 2014-04-21 16:43:50]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-04-21 16:43:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/243203002/40001

[commit-bot: I haz the power, 2014-04-21 23:47:42]

Change committed as 172091