Issue 2432001: Make Valgrind intercept TCMalloc's tc_{malloc,free,new,delete,..}...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2432001: Make Valgrind intercept TCMalloc's tc_{malloc,free,new,delete,..}... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years ago by Alexander Potapenko

Modified:
4 years ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, willchan no longer on Chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/valgrind/

Visibility:
Public.

Description

Make Valgrind intercept TCMalloc's tc_{malloc,free,new,delete,..} instead of {malloc,free,new,delete,..} Update the Memcheck/TSan binaries in the SVN. BUG=31951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48921

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -135 lines)			Patch
M	binaries/linux_x64/bin/no_op_client_for_valgrind	View		Binary file		0 comments	Download
M	binaries/linux_x64/bin/valgrind	View		Binary file		0 comments	Download
M	binaries/linux_x64/bin/valgrind-listener	View		Binary file		0 comments	Download
M	binaries/linux_x64/bin/valgrind-tsan.sh	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/memcheck-amd64-linux	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/memcheck-x86-linux	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/vgpreload_core-amd64-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/vgpreload_core-x86-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x86/bin/no_op_client_for_valgrind	View		Binary file		0 comments	Download
M	binaries/linux_x86/bin/valgrind	View		Binary file		0 comments	Download
M	binaries/linux_x86/bin/valgrind-listener	View		Binary file		0 comments	Download
M	binaries/linux_x86/bin/valgrind-tsan.sh	View		Binary file		0 comments	Download
M	binaries/linux_x86/lib/valgrind/memcheck-x86-linux	View		Binary file		0 comments	Download
M	binaries/linux_x86/lib/valgrind/vgpreload_core-x86-linux.so	View		Binary file		0 comments	Download
M	binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so	View		Binary file		0 comments	Download
M	scripts/intercept_tcmalloc.patch	View	1 2	2 chunks	+64 lines, -135 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

On 2010/05/31 14:00:23, Alexander Potapenko wrote: > PTAL

4 years, 12 months ago (2010-06-02 13:14:05 UTC) #2

Timur Iskhodzhanov

4 years, 12 months ago (2010-06-04 12:51:12 UTC) #3

LGTM provided you re-test and update the Mac binaries.

Expand Messages | Collapse Messages