Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2431963004: [Android] Always use devil's adb in the perf recipes. (Closed)

Created:
4 years, 2 months ago by jbudorick
Modified:
4 years, 2 months ago
CC:
chromium-reviews, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Always use devil's adb in the perf recipes. BUG=623989 Committed: https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1 Cr-Commit-Position: refs/heads/master@{#426368}

Patch Set 1 #

Patch Set 2 : revise TODO comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+968 lines, -375 lines) Patch
M infra/recipes/android/perf.py View 1 1 chunk +15 lines, -0 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json View 13 chunks +29 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__2_.json View 13 chunks +29 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__3_.json View 13 chunks +29 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus5_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json View 13 chunks +29 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__2_.json View 13 chunks +29 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__3_.json View 13 chunks +29 lines, -12 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus7v2_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_Nexus9_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__2_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_Android_One_Perf__3_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Power_Nexus_5X_Perf__1_.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/get_perf_test_list_old_data.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/host_info_failure.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/missing_device.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/provision_devices.json View 7 chunks +23 lines, -6 lines 0 comments Download
M infra/recipes/android/perf.expected/src_side_script_fails.json View 12 chunks +28 lines, -11 lines 0 comments Download
M infra/recipes/android/perf.expected/test_failure.json View 12 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jbudorick
More workarounds until we resolve https://github.com/catapult-project/catapult/issues/2901
4 years, 2 months ago (2016-10-19 21:49:51 UTC) #2
ghost stip (do not use)
lgtm
4 years, 2 months ago (2016-10-20 00:09:03 UTC) #3
dtu
lgtm
4 years, 2 months ago (2016-10-20 00:53:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431963004/20001
4 years, 2 months ago (2016-10-20 00:55:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 01:40:01 UTC) #7
nednguyen
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2437013002/ by nednguyen@google.com. ...
4 years, 2 months ago (2016-10-20 10:23:34 UTC) #8
jbudorick
On 2016/10/20 10:23:34, nednguyen wrote: > A revert of this CL (patchset #2 id:20001) has ...
4 years, 2 months ago (2016-10-20 13:44:44 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:14:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4a94bcadb9d91faf3e0b4124c9bfcb5546d82bc1
Cr-Commit-Position: refs/heads/master@{#426368}

Powered by Google App Engine
This is Rietveld 408576698