Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2431853002: Remove built-in path check from Quirks (Closed)

Created:
4 years, 2 months ago by Greg Levin
Modified:
4 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove built-in path check from Quirks BUG=650095 TEST=Winky and celes devices should now download 06af5c10.icc and 06af5c23.icc, respectively, to /var/cache/display_profiles/ Committed: https://crrev.com/f9f834f8e7e34cea08aff3f8834ffc2a81512fc4 Cr-Commit-Position: refs/heads/master@{#427518}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review (const &) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -74 lines) Patch
M ash/display/display_color_manager_chromeos_unittest.cc View 1 2 chunks +3 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/display/quirks_browsertest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/display/quirks_manager_delegate_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/chromeos/policy/device_quirks_policy_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/chromeos_paths.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/chromeos_paths.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/quirks/quirks_client.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/quirks/quirks_manager.h View 1 chunk +1 line, -5 lines 0 comments Download
M components/quirks/quirks_manager.cc View 1 4 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Greg Levin
Please have a look!
4 years, 2 months ago (2016-10-19 00:40:28 UTC) #6
oshima
lgtm https://codereview.chromium.org/2431853002/diff/1/components/quirks/quirks_manager.cc File components/quirks/quirks_manager.cc (right): https://codereview.chromium.org/2431853002/diff/1/components/quirks/quirks_manager.cc#newcode35 components/quirks/quirks_manager.cc:35: base::FilePath CheckForIccFile(base::FilePath path) { nit: const &
4 years, 1 month ago (2016-10-24 17:36:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431853002/20001
4 years, 1 month ago (2016-10-25 22:05:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 22:52:40 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 22:55:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9f834f8e7e34cea08aff3f8834ffc2a81512fc4
Cr-Commit-Position: refs/heads/master@{#427518}

Powered by Google App Engine
This is Rietveld 408576698