Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: remoting/protocol/webrtc_frame_scheduler_simple.h

Issue 2431843002: Update WebrtcFrameScheduler to avoid concurrent captures. (Closed)
Patch Set: comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/webrtc_dummy_video_encoder.h ('k') | remoting/protocol/webrtc_frame_scheduler_simple.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_frame_scheduler_simple.h
diff --git a/remoting/protocol/webrtc_frame_scheduler_simple.h b/remoting/protocol/webrtc_frame_scheduler_simple.h
index 6a38b39dd1bab9f6f5778c5778ccd3b70b04d566..f5f3702df83799f825994ef240314acfe724b7db 100644
--- a/remoting/protocol/webrtc_frame_scheduler_simple.h
+++ b/remoting/protocol/webrtc_frame_scheduler_simple.h
@@ -16,9 +16,10 @@
namespace remoting {
namespace protocol {
-// WebrtcFrameSchedulerSimple is a simple implementation of
-// WebrtcFrameScheduler that always keeps only one frame in the pipeline.
-// It schedules each frame after the previous one is expected to finish sending.
+// WebrtcFrameSchedulerSimple is a simple implementation of WebrtcFrameScheduler
+// that always keeps only one frame in the pipeline. It schedules each frame
+// such that it is encoded and ready to be sent by the time previous one is
+// expected to finish sending.
class WebrtcFrameSchedulerSimple : public VideoChannelStateObserver,
public WebrtcFrameScheduler {
public:
@@ -53,6 +54,9 @@ class WebrtcFrameSchedulerSimple : public VideoChannelStateObserver,
LeakyBucket pacing_bucket_;
+ // Set to true when a frame is being captured or encoded.
+ bool frame_pending_ = false;
+
// Set to true when encoding unchanged frames for top-off.
bool top_off_is_active_ = false;
« no previous file with comments | « remoting/protocol/webrtc_dummy_video_encoder.h ('k') | remoting/protocol/webrtc_frame_scheduler_simple.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698