Add shortcuts with a MAC

Add shortcuts with a MAC

Intentionally breaks old webapp shortcuts to change the package prefixes
in the Intent extras.

BUG=285924
R=dtrainor@chromium.org, palmer@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225290

[palmer, 2013-09-24 20:00:58]

LGTM with nit.

https://chromiumcodereview.appspot.com/24318004/diff/4001/chrome/android/java...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://chromiumcodereview.appspot.com/24318004/diff/4001/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:73: //
byte[] when adding the shortcut -- the launched Activity never even gets the
key.
Terminology nit: It's not a key (the key is secret), it's a MAC (the public
result of a private operation performed with the secret key). So I would say
"the launched Activity never even gets the MAC."

[gone, 2013-09-24 20:14:22]

https://chromiumcodereview.appspot.com/24318004/diff/4001/chrome/android/java...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://chromiumcodereview.appspot.com/24318004/diff/4001/chrome/android/java...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:73: //
byte[] when adding the shortcut -- the launched Activity never even gets the
key.
On 2013/09/24 20:00:58, Chromium Palmer wrote:
> Terminology nit: It's not a key (the key is secret), it's a MAC (the public
> result of a private operation performed with the secret key). So I would say
> "the launched Activity never even gets the MAC."

Er, I was referring to the key in the hash table of the Bundle that the Intent
stores.  I'll make this clearer.

[David Trainor- moved to gerrit, 2013-09-24 22:37:56]

lgtm

[gone, 2013-09-26 00:58:30]

No relevant tests failed.

[gone, 2013-09-26 01:00:15]

Committed patchset #5 manually as r225290 (presubmit successful).