Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2431783002: Add (shared) tests for ApiElementBuilder and ElementBuilder. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add (shared) tests for ApiElementBuilder and ElementBuilder. Also copy API-only tests from the old CL. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/529ebf7be28a65f1e3fcce49f8264ce3c070f755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1624 lines, -1495 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 13 chunks +39 lines, -30 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 37 chunks +1585 lines, -1465 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-18 19:18:50 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-18 19:26:11 UTC) #2
scheglov
4 years, 2 months ago (2016-10-18 19:28:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
529ebf7be28a65f1e3fcce49f8264ce3c070f755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698