chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java - Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java

Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer() (Closed)

Patch Set: Merge branch 'master' into webapk_embedded_test_server Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java

index 9de5c0bc18992533d38ee6465c9e976afa50ecef..88ddea19f7c5a3321423f33050511621b808f6c0 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageRequestTest.java

@@ -4,7 +4,6 @@

package org.chromium.chrome.browser.offlinepages;

-import android.os.Environment;

import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.base.ThreadUtils;

@@ -81,8 +80,8 @@ public class OfflinePageRequestTest extends ChromeActivityTestCaseBase<ChromeAct

@SmallTest

@RetryOnFailure

public void testLoadOfflinePageOnDisconnectedNetwork() throws Exception {

- EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartFileServer(

- getInstrumentation().getContext(), Environment.getExternalStorageDirectory());

+ EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartServer(

+ getInstrumentation().getContext());

String testUrl = testServer.getURL(TEST_PAGE);

String aboutUrl = testServer.getURL(ABOUT_PAGE);

@@ -116,8 +115,8 @@ public class OfflinePageRequestTest extends ChromeActivityTestCaseBase<ChromeAct

@SmallTest

@RetryOnFailure

public void testLoadOfflinePageWithFragmentOnDisconnectedNetwork() throws Exception {

- EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartFileServer(

- getInstrumentation().getContext(), Environment.getExternalStorageDirectory());

+ EmbeddedTestServer testServer =

+ EmbeddedTestServer.createAndStartServer(getInstrumentation().getContext());

String testUrl = testServer.getURL(TEST_PAGE);

String testUrlWithFragment = testUrl + "#ref";