chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java - Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java » ('j') | net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

index 70a9a15c9fad1b49c64775ee4f5873efa3a165cf..17527ae9866153f6d14ab4bd240dabc037348aa3 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java

@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.webapps;

import android.content.Context;

import android.os.Bundle;

-import android.os.Environment;

import android.test.suitebuilder.annotation.MediumTest;

import org.chromium.base.ThreadUtils;

@@ -98,8 +97,7 @@ public class ManifestUpgradeDetectorTest extends ChromeTabbedActivityTestBase {

protected void setUp() throws Exception {

super.setUp();

Context context = getInstrumentation().getTargetContext();

- mTestServer = EmbeddedTestServer.createAndStartFileServer(

- context, Environment.getExternalStorageDirectory());

+ mTestServer = EmbeddedTestServer.createAndStartServer(context);

mTab = getActivity().getActivityTab();

}