chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java - Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadTest.java » ('j') | net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

index ef65c68c690df9a9863d779366aa9e546a0af9c1..d3feae22d18d5e4f0ed6ab6a811c63f688fdd147 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java

@@ -6,7 +6,7 @@ package org.chromium.chrome.browser.download;

import android.app.DownloadManager;

import android.content.Context;

-import android.os.Environment;

import android.os.Handler;

import android.os.HandlerThread;

import android.test.suitebuilder.annotation.MediumTest;

@@ -567,8 +567,8 @@ public class DownloadManagerServiceTest extends NativeLibraryTestBase {

@MediumTest

@Feature({"Download"})

public void testEnqueueOMADownloads() throws InterruptedException {

- EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartFileServer(

- getInstrumentation().getContext(), Environment.getExternalStorageDirectory());

+ EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartServer(

+ getInstrumentation().getContext());

try {

DownloadInfo info = new DownloadInfo.Builder()