Mus experiment in content shell on Android.

services/ui/public/cpp/BUILD.gn

Index: services/ui/public/cpp/BUILD.gn
diff --git a/services/ui/public/cpp/BUILD.gn b/services/ui/public/cpp/BUILD.gn
index c8cf62b40547753a9240e750d4731302b2414010..daeea3a5303689bda4e9787e1e0613f00e2ac749 100644
--- a/services/ui/public/cpp/BUILD.gn
+++ b/services/ui/public/cpp/BUILD.gn
@@ -73,7 +73,11 @@ source_set("cpp") {
 source_set("internal_or_test") {
   visibility = [
     "./*",
-    "//services/ui/ws:mus_ws_unittests",
+
+    # We have to be visible to * because the test rule on Android generates
+    # sub-targets prefixed with mus_ws_unittests, but mus_ws_unittests* won't
+    # work in GN.
+    "//services/ui/ws/*",

[sky, 2016/10/18 21:52:30]

Is this working around a bug in gn? Can't we list all the targets?

[Jay Civelli, 2016/10/18 22:28:03]

We can... but there are a bunch and there are synthetic. Here is the list:

//services/ui/ws:mus_ws_unittests__isolate__write_deps
//services/ui/ws:_mus_ws_unittests__library
//services/ui/ws:mus_ws_unittests_apk__process_resources
//services/ui/ws:mus_ws_unittests_apk__java__compile_java__javac
//services/ui/ws:mus_ws_unittests_apk__java__compile_java__process_prebuilt__copy
//services/ui/ws:mus_ws_unittests_apk__create__package_resources
//services/ui/ws:mus_ws_unittests_apk__create__package
//services/ui/ws:mus_ws_unittests_apk__create_incremental_generate_manifest
//services/ui/ws:mus_ws_unittests_apk__create_incremental__package_resources
//services/ui/ws:mus_ws_unittests_apk__create_incremental__package

Sadly we cannot use mus_ws_unittests* in GN so it's either the full list or
//services/ui/ws/*

[sky, 2016/10/18 22:54:52]

Ugh! Ok, keep what you have.

     "//ui/views/mus:views_mus_unittests",
   ]
 
@@ -92,6 +96,7 @@ source_set("internal") {
   # the 'cpp' target.
   visibility = [
     ":cpp",
+    "//services/ui/demo:mus_demo_lib",
     "//services/ui/demo:mus_demo_library",
   ]