services/ui/mojo_ui_application_factory.cc - Issue 2431753002: Mus experiment in content shell on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/ui/mojo_ui_application_factory.cc

Issue 2431753002: Mus experiment in content shell on Android.

Patch Set: Fixed gn check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« services/ui/ime/test_ime_driver/mojo_test_ime_application_factory.cc ('K') | « services/ui/mojo_ui_application_factory.h ('k') | services/ui/public/cpp/BUILD.gn » ('j') | services/ui/public/cpp/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "services/ui/mojo_ui_application_factory.h"

	6

	7 #include "base/memory/ptr_util.h"

	8 #include "services/ui/service.h"

	9

	10 namespace ui {

	11

	12 // static

	13 std::unique_ptr<service_manager::Service> CreateMojoUIApplication(

	14 const base::Closure& quit_closure) {

	15 return std::unique_ptr<service_manager::Service>(new Service());
	sky 2016/10/18 21:52:30 Why do you need this function rather than having s Why do you need this function rather than having std::unique_ptr<service_manager::Service>(new Service()); directly? Jay Civelli 2016/10/18 22:28:02 This function is a factory function bound in shell Show quoted text On 2016/10/18 21:52:30, sky wrote: > Why do you need this function rather than having > std::unique_ptr<service_manager::Service>(new Service()); directly? This function is a factory function bound in shell_content_browser_client.cc so that the service manager can create the service directly. Jay Civelli 2016/10/19 00:42:04 Per our discussion, moved them to shell_content_br Show quoted text On 2016/10/18 22:28:02, Jay Civelli wrote: > On 2016/10/18 21:52:30, sky wrote: > > Why do you need this function rather than having > > std::unique_ptr<service_manager::Service>(new Service()); directly? > > This function is a factory function bound in shell_content_browser_client.cc so > that the service manager can create the service directly. Per our discussion, moved them to shell_content_browser_client.cc
	16 }

	17

	18 } // namespace ui

OLD	NEW