content/shell/android/java/res/layout/shell_view.xml - Issue 2431753002: Mus experiment in content shell on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/shell/android/java/res/layout/shell_view.xml

Issue 2431753002: Mus experiment in content shell on Android.

Patch Set: Fixed gn check Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/shell/android/BUILD.gn ('k') | content/shell/android/java/src/org/chromium/content_shell/Shell.java » ('j') | services/ui/ime/test_ime_driver/mojo_test_ime_application_factory.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2	2

3 <!-- Copyright 2012 The Chromium Authors. All rights reserved.	3 <!-- Copyright 2012 The Chromium Authors. All rights reserved.

4	4

5 Use of this source code is governed by a BSD-style license that can be	5 Use of this source code is governed by a BSD-style license that can be

6 found in the LICENSE file.	6 found in the LICENSE file.

7 -->	7 -->

8	8

9 <org.chromium.content_shell.Shell	9 <org.chromium.content_shell.Shell

10 xmlns:android="http://schemas.android.com/apk/res/android"	10 xmlns:android="http://schemas.android.com/apk/res/android"

(...skipping 28 matching lines...) Expand all Loading...
39 android:layout_height="38dp"	39 android:layout_height="38dp"

40 android:src="@android:drawable/ic_media_previous"	40 android:src="@android:drawable/ic_media_previous"

41 android:scaleType="center"	41 android:scaleType="center"

42 android:contentDescription="@null" />	42 android:contentDescription="@null" />

43 <ImageButton android:id="@+id/next"	43 <ImageButton android:id="@+id/next"

44 android:layout_width="38dp"	44 android:layout_width="38dp"

45 android:layout_height="38dp"	45 android:layout_height="38dp"

46 android:src="@android:drawable/ic_media_next"	46 android:src="@android:drawable/ic_media_next"

47 android:scaleType="center"	47 android:scaleType="center"

48 android:contentDescription="@null" />	48 android:contentDescription="@null" />

	49 <ImageButton android:id="@+id/show_mus"

	50 android:layout_width="38dp"

	51 android:layout_height="38dp"

	52 android:src="@android:drawable/btn_star"
	Ted C 2016/10/18 23:39:40 tiniest of nits, but I'd be worried about using a tiniest of nits, but I'd be worried about using a star as it might conflict w/ bookmarks. Is there some completely odd ball icon we can use instead? Jay Civelli 2016/10/19 00:42:04 Good point. Switched to using the gallery one. Let Show quoted text On 2016/10/18 23:39:40, Ted C wrote: > tiniest of nits, but I'd be worried about using a star as it might conflict w/ > bookmarks. Is there some completely odd ball icon we can use instead? Good point. Switched to using the gallery one. Let me know if you have a better suggestion.
	53 android:scaleType="center"

	54 android:contentDescription="@null"

	55 android:visibility="gone" />

49 </LinearLayout>	56 </LinearLayout>

50 <FrameLayout android:id="@+id/contentview_holder"	57 <FrameLayout android:id="@+id/contentview_holder"

51 android:layout_width="match_parent"	58 android:layout_width="match_parent"

52 android:layout_height="0dp"	59 android:layout_height="0dp"

53 android:layout_weight="1" />	60 android:layout_weight="1" />

54 </org.chromium.content_shell.Shell>	61 </org.chromium.content_shell.Shell>

OLD	NEW