Issue 2431733002: Add "not intended to be implemented/extended" warnings to pkg/front_end.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2431733002: Add "not intended to be implemented/extended" warnings to pkg/front_end. (Closed)

Created:
4 years, 2 months ago by Paul Berry

Modified:
4 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add "not intended to be implemented/extended" warnings to pkg/front_end. This ensures that we may safely add methods to the classes in this package without causing a breaking change. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8c42e5696437045bee9505735b0cb71ac2b00235

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
M	pkg/front_end/lib/compilation_error.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/compiler_options.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/front_end/lib/resolved_ast_generator.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 2 months ago (2016-10-18 20:31:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8c42e5696437045bee9505735b0cb71ac2b00235 (presubmit successful).