Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 243173002: Staging for cleanup of SkPicture-related headers (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Staging for cleanup of SkPicture-related headers This CL removes Skia's usage of the following headers (in preparation for their deletion): SkTileGridPicture.h SkQuadTreePicture.h SkRTreePictures.h but stages things so clients can still compile. It also consolidates all the SkBBHFactory-derived classes in SkBBHFactory.h and splits SkPictureRecorder into its own header. TBR=reed@google.com

Patch Set 1 #

Patch Set 2 : Base files missing fix #

Patch Set 3 : clean up & add missing files #

Patch Set 4 : Add crucial newline at end of file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -207 lines) Patch
M bench/PicturePlaybackBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/PictureRecordBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M bench/benchmain.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M debugger/SkDebugger.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M dm/DMReplayTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMTileGridTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMUtil.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/distantclip.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/gmmain.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/optimizations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/pathopsskpclip.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/pictureimagefilter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/pictureshader.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/core.gypi View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/core/SkBBHFactory.h View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +2 lines, -100 lines 0 comments Download
A include/core/SkPictureRecorder.h View 1 2 1 chunk +107 lines, -0 lines 0 comments Download
M include/core/SkRTreePicture.h View 1 2 1 chunk +6 lines, -8 lines 0 comments Download
M include/core/SkTileGridPicture.h View 1 chunk +6 lines, -31 lines 0 comments Download
M samplecode/SampleAll.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SamplePictFile.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M samplecode/SamplePicture.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleTiling.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkBBHFactory.cpp View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M src/core/SkPicture.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkPictureRecorder.cpp View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M src/core/SkQuadTreePicture.h View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M src/core/SkQuadTreePicture.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M src/core/SkRTreePicture.cpp View 1 2 1 chunk +2 lines, -16 lines 0 comments Download
M src/core/SkTileGrid.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkTileGridPicture.cpp View 1 chunk +2 lines, -16 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/TileGridTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tools/bench_record.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M tools/filtermain.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/render_pictures_main.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/skpmaker.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
robertphillips
6 years, 8 months ago (2014-04-18 15:48:10 UTC) #1
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-18 16:35:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/243173002/60001
6 years, 8 months ago (2014-04-18 16:35:23 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 16:35:36 UTC) #4
commit-bot: I haz the power
Presubmit check for 243173002-60001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-04-18 16:35:36 UTC) #5
reed1
lgtm
6 years, 8 months ago (2014-04-18 17:16:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 17:16:34 UTC) #7
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-18 17:16:34 UTC) #8
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 8 months ago (2014-04-18 17:16:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/243173002/60001
6 years, 8 months ago (2014-04-18 17:16:59 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 17:17:07 UTC) #11
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
6 years, 8 months ago (2014-04-18 17:17:07 UTC) #12
robertphillips
6 years, 8 months ago (2014-04-18 18:05:25 UTC) #13
Message was sent while issue was closed.
committed as r14258

Powered by Google App Engine
This is Rietveld 408576698