chrome/chrome_repack_locales.gni - Issue 2431653004: Setup Blimp internal string resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_repack_locales.gni

Issue 2431653004: Setup Blimp internal string resources. (Closed)

Patch Set: Fixes for feedback. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/public/resources/BUILD.gn ('K') | « chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc ('k') | tools/gritsettings/resource_ids » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_repack_locales.gni

diff --git a/chrome/chrome_repack_locales.gni b/chrome/chrome_repack_locales.gni

index 62706f125de6a70f1250d70cd9c2aece63b9aed6..602d542abf08abb5931b2778f3f44a848ad0c4b4 100644

--- a/chrome/chrome_repack_locales.gni

+++ b/chrome/chrome_repack_locales.gni

@@ -56,7 +56,6 @@ template("chrome_repack_locales") {

}

if (!is_ios) {

source_patterns += [

- "${root_gen_dir}/blimp/client/support/resources/blimp_strings_",

"${root_gen_dir}/content/app/strings/content_strings_",

"${root_gen_dir}/device/bluetooth/strings/bluetooth_strings_",

"${root_gen_dir}/third_party/libaddressinput/address_input_strings_",

@@ -64,7 +63,6 @@ template("chrome_repack_locales") {

"${root_gen_dir}/ui/strings/ui_strings_",

]

deps += [

- "//blimp/client/support/resources:strings",

"//content/app/strings",

"//device/bluetooth/strings",

"//third_party/libaddressinput:strings",

@@ -72,6 +70,16 @@ template("chrome_repack_locales") {

"//ui/strings:ui_strings",

]

}

+ if (is_android) {

+ source_patterns += [

+ "${root_gen_dir}/blimp/client/public/resources/blimp_strings_",

+ "${root_gen_dir}/blimp/client/support/resources/blimp_strings_",

+ ]

+ deps += [

+ "//blimp/client/public/resources:strings",

+ "//blimp/client/support/resources:strings",

+ ]

+ }

if (enable_extensions) {

source_patterns +=

[ "${root_gen_dir}/extensions/strings/extensions_strings_" ]