Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: blimp/client/app/BUILD.gn

Issue 2431653004: Setup Blimp internal string resources. (Closed)
Patch Set: Fixes for feedback. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/BUILD.gn
diff --git a/blimp/client/app/BUILD.gn b/blimp/client/app/BUILD.gn
index 8da4cb824b2bcd31ab8e8710fab0776520ece758..8a653e2134e8dda3dbb0872c52d504de2f2678d4 100644
--- a/blimp/client/app/BUILD.gn
+++ b/blimp/client/app/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/config/ui.gni")
+import("//tools/grit/repack.gni")
if (is_android) {
import("//build/config/android/config.gni")
@@ -51,6 +52,7 @@ source_set("app") {
"//gpu/skia_bindings",
"//net",
"//third_party/libwebp",
+ "//ui/base:base",
"//ui/gfx/geometry",
"//ui/gl",
"//ui/gl/init",
@@ -140,8 +142,10 @@ if (is_linux && !is_chromeos && use_x11) {
deps = [
":app",
+ ":pak",
"//base",
"//blimp/client/core/compositor",
+ "//blimp/client/core/resources",
"//blimp/client/core/session",
"//blimp/net",
"//net",
@@ -163,6 +167,19 @@ if (is_linux && !is_chromeos && use_x11) {
}
}
+# Resources file for linux client.
+repack("pak") {
+ sources = [
+ "$root_gen_dir/blimp/client/core/resources/blimp_strings_en-US.pak",
+ ]
+
+ deps = [
+ "//blimp/client/public/resources:app_strings",
David Trainor- moved to gerrit 2016/10/28 04:20:08 Can we call this something that sounds test/shell
xingliu 2016/10/28 22:50:31 Done.
+ ]
+
+ output = "$root_out_dir/blimp_shell.pak"
+}
+
if (is_android) {
declare_args() {
# Package name used in the manifest for the Blimp APK.

Powered by Google App Engine
This is Rietveld 408576698