Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2431633002: libyuv: Set symbol_level=1 for Android builders. (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

libyuv: Set symbol_level=1 for Android builders. Android 32-bit non-component, non-clang builds cannot have symbol_level=2 due to 4GiB file size limit, see https://crbug.com/648948 BUG=chromium:652188 TBR=ehmaldonado@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/8063186c66ba88cfed50669b331771266edc863d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M scripts/slave/recipe_modules/libyuv/chromium_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_x86_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android64_x64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_arm64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug_forced.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x86.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_chromium
4 years, 2 months ago (2016-10-18 11:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431633002/1
4 years, 2 months ago (2016-10-18 11:06:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/8063186c66ba88cfed50669b331771266edc863d
4 years, 2 months ago (2016-10-18 11:15:20 UTC) #7
kjellander_chromium
On 2016/10/18 11:15:20, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 2 months ago (2016-10-18 11:33:57 UTC) #10
kjellander_chromium
On 2016/10/18 11:15:20, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 2 months ago (2016-10-18 11:37:31 UTC) #11
kjellander_chromium
4 years, 2 months ago (2016-10-18 19:11:05 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2429883002/ by kjellander@chromium.org.

The reason for reverting is: The GN command somehow puts symbol_level=2 into the
GN args anyway, so this CL just makes things worse (symbol_level being specified
twice)..

Powered by Google App Engine
This is Rietveld 408576698