Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 2431533002: PlzNavigate: Enable the ContinueWhereILeftOffTest.PostWithPassword test. (Closed)

Created:
4 years, 2 months ago by ananta
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Enable the ContinueWhereILeftOffTest.PostWithPassword test. Enable this test. BUG=655422 Committed: https://crrev.com/0bfce19cb62429f32b742ed00c66ba90214821bc Cr-Commit-Position: refs/heads/master@{#426079}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Update filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
ananta
4 years, 2 months ago (2016-10-18 01:30:35 UTC) #2
jam
lgtm with more tests running :) https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter File testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter (left): https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter#oldcode6 testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:6: -ContinueWhereILeftOffTest.PostWithPasswordCloseAllBrowsers looks like ...
4 years, 2 months ago (2016-10-18 15:54:36 UTC) #7
ananta
https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter File testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter (left): https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter#oldcode6 testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:6: -ContinueWhereILeftOffTest.PostWithPasswordCloseAllBrowsers On 2016/10/18 15:54:36, jam wrote: > looks like ...
4 years, 2 months ago (2016-10-18 21:02:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431533002/20001
4 years, 2 months ago (2016-10-18 21:05:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/297900)
4 years, 2 months ago (2016-10-18 22:01:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431533002/20001
4 years, 2 months ago (2016-10-18 22:09:08 UTC) #15
commit-bot: I haz the power
Exceeded global retry quota
4 years, 2 months ago (2016-10-18 22:46:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431533002/20001
4 years, 2 months ago (2016-10-18 23:01:17 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 23:08:51 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:04:23 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bfce19cb62429f32b742ed00c66ba90214821bc
Cr-Commit-Position: refs/heads/master@{#426079}

Powered by Google App Engine
This is Rietveld 408576698