|
|
Chromium Code Reviews
DescriptionPlzNavigate: Enable the ContinueWhereILeftOffTest.PostWithPassword test.
Enable this test.
BUG=655422
Committed: https://crrev.com/0bfce19cb62429f32b742ed00c66ba90214821bc
Cr-Commit-Position: refs/heads/master@{#426079}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Update filter #Messages
Total messages: 22 (12 generated)
ananta@chromium.org changed reviewers: + jam@chromium.org
The CQ bit was checked by ananta@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with more tests running :) https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/br... File testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter (left): https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/br... testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:6: -ContinueWhereILeftOffTest.PostWithPasswordCloseAllBrowsers looks like all three of these are fixed now https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/br... testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:36: -RestartTest.PostWithPassword this works now too
https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/br... File testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter (left): https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/br... testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:6: -ContinueWhereILeftOffTest.PostWithPasswordCloseAllBrowsers On 2016/10/18 15:54:36, jam wrote: > looks like all three of these are fixed now Thanks. Removed https://codereview.chromium.org/2431533002/diff/1/testing/buildbot/filters/br... testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter:36: -RestartTest.PostWithPassword On 2016/10/18 15:54:36, jam wrote: > this works now too Thanks. Done
The CQ bit was checked by ananta@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org Link to the patchset: https://codereview.chromium.org/2431533002/#ps20001 (title: "Update filter")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ananta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by ananta@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== PlzNavigate: Enable the ContinueWhereILeftOffTest.PostWithPassword test. Enable this test. BUG=655422 ========== to ========== PlzNavigate: Enable the ContinueWhereILeftOffTest.PostWithPassword test. Enable this test. BUG=655422 Committed: https://crrev.com/0bfce19cb62429f32b742ed00c66ba90214821bc Cr-Commit-Position: refs/heads/master@{#426079} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0bfce19cb62429f32b742ed00c66ba90214821bc Cr-Commit-Position: refs/heads/master@{#426079} |
