Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2431523002:
Use the hermetic toolchain if FORCE_MAC_TOOLCHAIN is set. (Closed)
DescriptionUse the hermetic toolchain if FORCE_MAC_TOOLCHAIN is set.
FORCE_MAC_TOOLCHAIN is set for all macs in the infra fleet, so this CL turns on
hermetic xcode + GN for all machines.
BUG=626093
Committed: https://crrev.com/2803b8efa6c51080f02fa764e67a986abf078f88
Cr-Commit-Position: refs/heads/master@{#427110}
Patch Set 1 #Patch Set 2 : Add file. #
Total comments: 2
Patch Set 3 : Comments from dpranke. #
Total comments: 2
Patch Set 4 : Comments from brettw. #Patch Set 5 : Remove .gn changes. #Patch Set 6 : make sure that use_system_xcode gets a default value on ios as well. #Messages
Total messages: 31 (21 generated)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + dpranke@chromium.org
dpranke: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
lgtm w/ nit. https://codereview.chromium.org/2431523002/diff/20001/build/toolchain/toolcha... File build/toolchain/toolchain.gni (right): https://codereview.chromium.org/2431523002/diff/20001/build/toolchain/toolcha... build/toolchain/toolchain.gni:55: use_system_xcode = _result[0] == "0" If you use "value" instead of "list lines" you can write just `_result = exec_script(...) == "0"`.
https://codereview.chromium.org/2431523002/diff/20001/build/toolchain/toolcha... File build/toolchain/toolchain.gni (right): https://codereview.chromium.org/2431523002/diff/20001/build/toolchain/toolcha... build/toolchain/toolchain.gni:55: use_system_xcode = _result[0] == "0" On 2016/10/18 01:51:58, Dirk Pranke wrote: > If you use "value" instead of "list lines" you can write just `_result = > exec_script(...) == "0"`. Done.
erikchen@chromium.org changed reviewers: + brettw@chromium.org
brettw: Please review .gn
https://codereview.chromium.org/2431523002/diff/40001/build/toolchain/toolcha... File build/toolchain/toolchain.gni (right): https://codereview.chromium.org/2431523002/diff/40001/build/toolchain/toolcha... build/toolchain/toolchain.gni:53: _result = exec_script("//build/mac/should_use_hermetic_xcode.py", [], "value") GN has a "getenv" function. Can you use that here?
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
https://codereview.chromium.org/2431523002/diff/40001/build/toolchain/toolcha... File build/toolchain/toolchain.gni (right): https://codereview.chromium.org/2431523002/diff/40001/build/toolchain/toolcha... build/toolchain/toolchain.gni:53: _result = exec_script("//build/mac/should_use_hermetic_xcode.py", [], "value") On 2016/10/19 20:38:32, brettw (ping on IM after 24h) wrote: > GN has a "getenv" function. Can you use that here? How convenient. Done. This also removes the dependency on .gn, and hence the need for another pass from you. ;)
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM anyway
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2431523002/#ps100001 (title: "make sure that use_system_xcode gets a default value on ios as well.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Use the hermetic toolchain if FORCE_MAC_TOOLCHAIN is set. FORCE_MAC_TOOLCHAIN is set for all macs in the infra fleet, so this CL turns on hermetic xcode + GN for all machines. BUG=626093 ========== to ========== Use the hermetic toolchain if FORCE_MAC_TOOLCHAIN is set. FORCE_MAC_TOOLCHAIN is set for all macs in the infra fleet, so this CL turns on hermetic xcode + GN for all machines. BUG=626093 Committed: https://crrev.com/2803b8efa6c51080f02fa764e67a986abf078f88 Cr-Commit-Position: refs/heads/master@{#427110} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/2803b8efa6c51080f02fa764e67a986abf078f88 Cr-Commit-Position: refs/heads/master@{#427110} |
