Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 24315007: Avoid fallback to weak entropy for the PRNGs on Windows. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid fallback to weak entropy for the PRNGs on Windows. Add fallback to rand_s() to gather entropy on Windows for seeding the random number generator. This is compatible with what Blink does. BUG=v8:2905 R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16920

Patch Set 1 #

Total comments: 2

Patch Set 2 : REBASE #

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/utils/random-number-generator.cc View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
PTAL
7 years, 3 months ago (2013-09-24 07:45:33 UTC) #1
Benedikt Meurer
CC'ing Dan.
7 years, 3 months ago (2013-09-24 07:51:56 UTC) #2
Michael Achenbach
https://codereview.chromium.org/24315007/diff/1/src/utils/random-number-generator.cc File src/utils/random-number-generator.cc (right): https://codereview.chromium.org/24315007/diff/1/src/utils/random-number-generator.cc#newcode71 src/utils/random-number-generator.cc:71: #if V8_OS_CYGIN || V8_OS_WIN CYGWIN
7 years, 3 months ago (2013-09-24 12:55:39 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/24315007/diff/1/src/utils/random-number-generator.cc File src/utils/random-number-generator.cc (right): https://codereview.chromium.org/24315007/diff/1/src/utils/random-number-generator.cc#newcode71 src/utils/random-number-generator.cc:71: #if V8_OS_CYGIN || V8_OS_WIN On 2013/09/24 12:55:41, machenbach wrote: ...
7 years, 3 months ago (2013-09-24 13:24:51 UTC) #4
Michael Achenbach
lgtm
7 years, 3 months ago (2013-09-24 13:26:15 UTC) #5
Benedikt Meurer
7 years, 3 months ago (2013-09-24 13:28:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r16920 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698